Skip to content

Conversation

@sunzhaohua2
Copy link
Contributor

Since the master branch has already switch to sync with 4.20, we need to change the master/release-4.20 configs' the test image tag to 4.20.
Also corrected other tags.
@huali9 @miyadav PTAL

@openshift-ci openshift-ci bot requested review from damdo and elmiko May 28, 2025 09:59
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@sunzhaohua2: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-cluster-control-plane-machine-set-operator-release-4.19-e2e-aws-operator openshift/cluster-control-plane-machine-set-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-control-plane-machine-set-operator-release-4.19-e2e-aws-operator-techpreview openshift/cluster-control-plane-machine-set-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-control-plane-machine-set-operator-release-4.19-e2e-aws-ovn openshift/cluster-control-plane-machine-set-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-control-plane-machine-set-operator-release-4.19-e2e-aws-ovn-etcd-scaling openshift/cluster-control-plane-machine-set-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-control-plane-machine-set-operator-release-4.19-e2e-aws-ovn-serial-1of2 openshift/cluster-control-plane-machine-set-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-control-plane-machine-set-operator-release-4.19-e2e-aws-ovn-serial-2of2 openshift/cluster-control-plane-machine-set-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-control-plane-machine-set-operator-release-4.19-e2e-aws-ovn-upgrade openshift/cluster-control-plane-machine-set-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-control-plane-machine-set-operator-release-4.19-e2e-aws-periodic-pre openshift/cluster-control-plane-machine-set-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-control-plane-machine-set-operator-release-4.19-e2e-aws-periodic-pre-techpreview openshift/cluster-control-plane-machine-set-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-control-plane-machine-set-operator-release-4.19-e2e-azure-operator openshift/cluster-control-plane-machine-set-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-control-plane-machine-set-operator-release-4.19-e2e-azure-ovn-etcd-scaling openshift/cluster-control-plane-machine-set-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-control-plane-machine-set-operator-release-4.19-e2e-azure-periodic-pre openshift/cluster-control-plane-machine-set-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-control-plane-machine-set-operator-release-4.19-e2e-azure-periodic-pre-techpreview openshift/cluster-control-plane-machine-set-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-control-plane-machine-set-operator-release-4.19-e2e-gcp-operator openshift/cluster-control-plane-machine-set-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-control-plane-machine-set-operator-release-4.19-e2e-gcp-ovn-etcd-scaling openshift/cluster-control-plane-machine-set-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-control-plane-machine-set-operator-release-4.19-e2e-gcp-periodic-pre openshift/cluster-control-plane-machine-set-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-control-plane-machine-set-operator-release-4.19-e2e-gcp-periodic-pre-techpreview openshift/cluster-control-plane-machine-set-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-control-plane-machine-set-operator-release-4.19-e2e-nutanix-ovn openshift/cluster-control-plane-machine-set-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-control-plane-machine-set-operator-release-4.19-e2e-openstack-operator openshift/cluster-control-plane-machine-set-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-control-plane-machine-set-operator-release-4.19-e2e-openstack-operator-zone openshift/cluster-control-plane-machine-set-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-control-plane-machine-set-operator-release-4.19-e2e-openstack-periodic-pre openshift/cluster-control-plane-machine-set-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-control-plane-machine-set-operator-release-4.19-e2e-openstack-periodic-pre-techpreview openshift/cluster-control-plane-machine-set-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-control-plane-machine-set-operator-release-4.19-e2e-vsphere-multi-vcenter-operator openshift/cluster-control-plane-machine-set-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-control-plane-machine-set-operator-release-4.19-e2e-vsphere-multi-zone-operator openshift/cluster-control-plane-machine-set-operator presubmit Ci-operator config changed
pull-ci-openshift-cluster-control-plane-machine-set-operator-release-4.19-e2e-vsphere-operator openshift/cluster-control-plane-machine-set-operator presubmit Ci-operator config changed

A total of 1308 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@sunzhaohua2 sunzhaohua2 changed the title update cluster infra tests-private test image tags OCPQE-29800: update cluster infra tests-private test image tags May 28, 2025
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 28, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 28, 2025

@sunzhaohua2: This pull request references OCPQE-29800 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

Since the master branch has already switch to sync with 4.20, we need to change the master/release-4.20 configs' the test image tag to 4.20.
Also corrected other tags.
@huali9 @miyadav PTAL

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@huali9
Copy link
Contributor

huali9 commented May 29, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 29, 2025
Copy link
Member

@damdo damdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For 4.21 we use 4.20?

@sunzhaohua2
Copy link
Contributor Author

For 4.21 we use 4.20?

Yes, confirmed with @liangxia codes in branch 4.20, 4.21, and master we use use 4.20 currently

Copy link
Member

@damdo damdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@sunzhaohua2 Do we need to revert this later or will this stay like this?

How will it work with the -main.yaml files, how will they follow the latest images when 4.21 is available?

@sunzhaohua2
Copy link
Contributor Author

/approve

@sunzhaohua2 Do we need to revert this later or will this stay like this?

How will it work with the -main.yaml files, how will they follow the latest images when 4.21 is available?

@damdo I created a card for 4.20 to update the image tag, in the future whenever there is a new branch, I will update the image version in -main.yaml files

@damdo
Copy link
Member

damdo commented May 29, 2025

/assign @JoelSpeed

for the remaining approvals

@JoelSpeed
Copy link
Contributor

/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 29, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damdo, huali9, JoelSpeed, sunzhaohua2

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 29, 2025
@sunzhaohua2
Copy link
Contributor Author

/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@sunzhaohua2: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 29, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit e1e05ee into openshift:master May 29, 2025
12 of 13 checks passed
abraham2512 pushed a commit to abraham2512/release that referenced this pull request May 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants