Merge pull request #3086 from stbenjam/test-details-prompt

TRT-2393: fix(chat): prevent LLM from modifying test_details URL parameters

Author: openshift-merge-bot[bot]

chat/sippy_agent/tools/sippy_test_details.py

@@ -19,7 +19,7 @@ class SippyTestDetailsTool(SippyBaseTool):
 
     name: str = "get_test_details_report"
     description: str = """Get a test details report from Sippy API including regression analysis and statistics.
-    
+
 This tool provides:
 - Regression status and history
 - Sample vs base statistics comparison
@@ -31,13 +31,13 @@ class SippyTestDetailsTool(SippyBaseTool):
 - Triage information
 - Pass rate changes
 
-Input: query_params (the query parameters for the test details endpoint, e.g., testId=12345&component=...&baseRelease=...)"""
+Input: url (the test details URL, passed verbatim without modification)"""
 
     # Add sippy_api_url as a proper field
     sippy_api_url: Optional[str] = Field(default=None, description="Sippy API base URL")
 
     class TestDetailsInput(SippyToolInput):
-        query_params: str = Field(description="Query parameters for the test details endpoint. Can be either just the query params (e.g., testId=12345&component=foo) or a full URL (the query params will be extracted)")
+        url: str = Field(description="The test details URL. Pass the URL exactly as provided without any modifications.")
 
     args_schema: Type[SippyToolInput] = TestDetailsInput
 
@@ -60,17 +60,20 @@ def _run(self, *args, **kwargs: Any) -> Dict[str, Any]:
                 "error": "No Sippy API URL configured. Please set SIPPY_API_URL environment variable."
             }
 
-        # Build the full URL from query params
-        query_params = args.query_params.strip()
-        
-        # If query_params is a full URL, extract just the query string
-        if query_params.startswith('http') or query_params.startswith('/'):
+        # Build the full URL from the provided URL/query params
+        url_input = args.url.strip()
+
+        # If url_input is a full URL, extract just the query string
+        if url_input.startswith('http') or url_input.startswith('/'):
             # Extract query params from URL
-            if '?' in query_params:
-                query_params = query_params.split('?', 1)[1]
+            if '?' in url_input:
+                query_params = url_input.split('?', 1)[1]
             else:
-                return {"error": f"No query parameters found in URL: {query_params}"}
-        
+                return {"error": f"No query parameters found in URL: {url_input}"}
+        else:
+            # It's just query params
+            query_params = url_input
+
         # Ensure query params don't start with ? or &
         if query_params.startswith('?') or query_params.startswith('&'):
             query_params = query_params[1:]