Improve automated support for local webhooks #262
Merged
+44
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrkisaolamb
reviewed
Oct 31, 2024
abays
force-pushed
the
improve_local_webhooks
branch
from
ce6b1ee to
0c837cc
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abays, mrkisaolamb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit e6705df
into
openstack-k8s-operators:main
6 checks passed
|
so i dont know about you but my workflow was always to rung the operator once with the make target to get everything setup up and then control c it then run it under a debugger. so automatically cleaning them on contol-c is not the behavior i would generally want. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworks
make run-with-webhooktarget to trapSIGINTandSIGTERMso as to callclean_local_webhook.shin such a scenario. This way, a user can run the operator locally and automatically have the local webhooks removed when they finish running the operator viactrl+c.Also creates a backup of any existing OLM CSV for the operator while preparing to run the operator locally with webhooks, if the current CSV has a deployment
replicascount greater than zero and/or there arewebhookdefinitionspresent. That backup can then be easily re-applied to restore OLM CSV defaults viaoc patchby the user at their convenience. I left the existingmakescale-down-placement-controller-csvtarget alone, even though its functionality is covered now inhack/run_with_local_webhook.sh. It seemed that maybe it could still be useful in isolation.