From 690749ffe43cc70873c612bccbcdb19edd18c3a1 Mon Sep 17 00:00:00 2001 From: Benoit Pierre Date: Sun, 12 Dec 2021 04:31:14 +0100 Subject: [PATCH 1/3] gui/paper_tape: fix handling of paper mode header It was not updated on system change. --- plover/gui_qt/paper_tape.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/plover/gui_qt/paper_tape.py b/plover/gui_qt/paper_tape.py index 70cbfe3b0..f31210d4e 100644 --- a/plover/gui_qt/paper_tape.py +++ b/plover/gui_qt/paper_tape.py @@ -163,7 +163,8 @@ def _save_state(self, settings): def on_config_changed(self, config): if 'system_name' in config: - self._model.reset() + all_keys = self._model.reset() + self.header.setText(all_keys) @property def _scroll_at_end(self): From 33c3a7a591ed90f9cdf453041442ce179cd5bbfd Mon Sep 17 00:00:00 2001 From: Benoit Pierre Date: Sun, 12 Dec 2021 04:32:10 +0100 Subject: [PATCH 2/3] gui_qt/paper_tape: remove dead code --- plover/gui_qt/paper_tape.py | 6 ------ 1 file changed, 6 deletions(-) diff --git a/plover/gui_qt/paper_tape.py b/plover/gui_qt/paper_tape.py index f31210d4e..76e94d241 100644 --- a/plover/gui_qt/paper_tape.py +++ b/plover/gui_qt/paper_tape.py @@ -67,12 +67,6 @@ def _paper_format(self, stroke): def _raw_format(stroke): return stroke.rtfcre - def headerData(self, section, orientation, role): - if (section != 0 or orientation != Qt.Horizontal or - role != Qt.DisplayRole or self._style != STYLE_PAPER): - return None - return self._all_keys - def data(self, index, role): if not index.isValid(): return None From 263effa4f8fddb0d2d2cea6708ce1586c9356dea Mon Sep 17 00:00:00 2001 From: Benoit Pierre Date: Sun, 12 Dec 2021 21:57:25 +0100 Subject: [PATCH 3/3] add news entry --- news.d/feature/1451.ui.md | 6 ++++++ 1 file changed, 6 insertions(+) create mode 100644 news.d/feature/1451.ui.md diff --git a/news.d/feature/1451.ui.md b/news.d/feature/1451.ui.md new file mode 100644 index 000000000..c1e969845 --- /dev/null +++ b/news.d/feature/1451.ui.md @@ -0,0 +1,6 @@ +Improve accessibility: +- Disable tab-key navigation in tables, so focusing a table does not lock global tab-key navigation to it. +- Remove some container widgets, tweak focus rules to avoid extra unnecessary steps when using tab-key navigation (like selecting the dictionaries widget outer frame). +- In form layouts, link each widget to its label (like each option in the configuration dialog). +- Set the accessible name / description of focusable widgets. +- Use lists for the dictionaries widget, suggestions widget, and the paper tape.