From ff4043ae581d397b6a43c3c4521646e2ae71d738 Mon Sep 17 00:00:00 2001 From: Tobias Zwick Date: Sun, 28 Apr 2019 17:47:27 +0200 Subject: [PATCH 1/3] Add presets for bicycle parkings... ... that are not essentially just a type of bicycle stands --- .../amenity/bicycle_parking/building.json | 23 +++++++++++++ .../amenity/bicycle_parking/lockers.json | 19 +++++++++++ .../presets/amenity/bicycle_parking/shed.json | 33 +++++++++++++++++++ 3 files changed, 75 insertions(+) create mode 100644 data/presets/presets/amenity/bicycle_parking/building.json create mode 100644 data/presets/presets/amenity/bicycle_parking/lockers.json create mode 100644 data/presets/presets/amenity/bicycle_parking/shed.json diff --git a/data/presets/presets/amenity/bicycle_parking/building.json b/data/presets/presets/amenity/bicycle_parking/building.json new file mode 100644 index 0000000000..56483d1747 --- /dev/null +++ b/data/presets/presets/amenity/bicycle_parking/building.json @@ -0,0 +1,23 @@ +{ + "icon": "maki-bicycle", + "fields": [ + "{amenity/bicycle_parking}", + "opening_hours" + ], + "geometry": [ + "point", + "vertex", + "area" + ], + "tags": { + "amenity": "bicycle_parking", + "bicycle_parking": "building" + }, + "reference": { + "key": "bicycle_parking" + }, + "terms": [ + "Multi-storey bicycle park" + ], + "name": "Bicycle parking station" +} diff --git a/data/presets/presets/amenity/bicycle_parking/lockers.json b/data/presets/presets/amenity/bicycle_parking/lockers.json new file mode 100644 index 0000000000..5dfedfadb6 --- /dev/null +++ b/data/presets/presets/amenity/bicycle_parking/lockers.json @@ -0,0 +1,19 @@ +{ + "icon": "maki-bicycle", + "geometry": [ + "point", + "vertex", + "area" + ], + "tags": { + "amenity": "bicycle_parking", + "bicycle_parking": "lockers" + }, + "reference": { + "key": "bicycle_parking" + }, + "terms": [ + "Bike lockers" + ], + "name": "Bicycle lockers" +} diff --git a/data/presets/presets/amenity/bicycle_parking/shed.json b/data/presets/presets/amenity/bicycle_parking/shed.json new file mode 100644 index 0000000000..ededa7ba5b --- /dev/null +++ b/data/presets/presets/amenity/bicycle_parking/shed.json @@ -0,0 +1,33 @@ +{ + "icon": "maki-bicycle", + "fields": [ + "{amenity/bicycle_parking}", + "building" + ], + "geometry": [ + "point", + "vertex", + "area" + ], + "tags": { + "amenity": "bicycle_parking", + "bicycle_parking": "shed" + }, + "addTags": { + "building": "shed", + "amenity": "bicycle_parking", + "bicycle_parking": "shed" + }, + "removeTags": { + "building": "shed", + "amenity": "bicycle_parking", + "bicycle_parking": "shed" + }, + "reference": { + "key": "bicycle_parking" + }, + "terms": [ + "Bike shed" + ], + "name": "Bicycle shed" +} From 92c438a9e7d0f8b875ae89a0cf1969b4839492b5 Mon Sep 17 00:00:00 2001 From: Tobias Zwick Date: Mon, 29 Apr 2019 00:15:21 +0200 Subject: [PATCH 2/3] capitalize names --- data/presets/presets/amenity/bicycle_parking/building.json | 6 ++++-- data/presets/presets/amenity/bicycle_parking/lockers.json | 4 ++-- data/presets/presets/amenity/bicycle_parking/shed.json | 4 ++-- 3 files changed, 8 insertions(+), 6 deletions(-) diff --git a/data/presets/presets/amenity/bicycle_parking/building.json b/data/presets/presets/amenity/bicycle_parking/building.json index 56483d1747..369b80cc1c 100644 --- a/data/presets/presets/amenity/bicycle_parking/building.json +++ b/data/presets/presets/amenity/bicycle_parking/building.json @@ -17,7 +17,9 @@ "key": "bicycle_parking" }, "terms": [ - "Multi-storey bicycle park" + "Multi-Storey Bicycle Park", + "Multi-Storey Bike Park", + "Bike Parking Station" ], - "name": "Bicycle parking station" + "name": "Bicycle Parking Station" } diff --git a/data/presets/presets/amenity/bicycle_parking/lockers.json b/data/presets/presets/amenity/bicycle_parking/lockers.json index 5dfedfadb6..34b60afc1e 100644 --- a/data/presets/presets/amenity/bicycle_parking/lockers.json +++ b/data/presets/presets/amenity/bicycle_parking/lockers.json @@ -13,7 +13,7 @@ "key": "bicycle_parking" }, "terms": [ - "Bike lockers" + "Bike Lockers" ], - "name": "Bicycle lockers" + "name": "Bicycle Lockers" } diff --git a/data/presets/presets/amenity/bicycle_parking/shed.json b/data/presets/presets/amenity/bicycle_parking/shed.json index ededa7ba5b..0b9fcd44e3 100644 --- a/data/presets/presets/amenity/bicycle_parking/shed.json +++ b/data/presets/presets/amenity/bicycle_parking/shed.json @@ -27,7 +27,7 @@ "key": "bicycle_parking" }, "terms": [ - "Bike shed" + "Bike Shed" ], - "name": "Bicycle shed" + "name": "Bicycle Shed" } From 0656ceff63da6f25a3b88e314877f76e81517bc3 Mon Sep 17 00:00:00 2001 From: Tobias Zwick Date: Mon, 29 Apr 2019 19:50:40 +0200 Subject: [PATCH 3/3] remove building=shed from bicycle_parking=shed preset building=shed should not be added if the geometry is a point, but should, if possible, if it is an area. Unfortunately, the iD preset system is currently not able to map this behavior to a preset. Instead, there is the building_area field which automatically adds building=yes to the preset if it is an area. --- .../presets/amenity/bicycle_parking/shed.json | 12 +----------- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/data/presets/presets/amenity/bicycle_parking/shed.json b/data/presets/presets/amenity/bicycle_parking/shed.json index 0b9fcd44e3..cbd45b90a0 100644 --- a/data/presets/presets/amenity/bicycle_parking/shed.json +++ b/data/presets/presets/amenity/bicycle_parking/shed.json @@ -2,7 +2,7 @@ "icon": "maki-bicycle", "fields": [ "{amenity/bicycle_parking}", - "building" + "building_area" ], "geometry": [ "point", @@ -13,16 +13,6 @@ "amenity": "bicycle_parking", "bicycle_parking": "shed" }, - "addTags": { - "building": "shed", - "amenity": "bicycle_parking", - "bicycle_parking": "shed" - }, - "removeTags": { - "building": "shed", - "amenity": "bicycle_parking", - "bicycle_parking": "shed" - }, "reference": { "key": "bicycle_parking" },