From eeca6f118aed4f731e8d94568c75e80402ceb808 Mon Sep 17 00:00:00 2001
From: Tobias <tobias@fixmycity.de>
Date: Mon, 10 Jan 2022 21:31:16 +0100
Subject: [PATCH] Add traffic_sign=DE:240 presets

- only for Germany, since it's a German traffic sign
- one preset for the tagging in combination with `highway=path`, which is dominant (25k) and one un-searchable for `highway=cycleway` (3k) https://taginfo.openstreetmap.org/tags/?key=traffic_sign&value=DE%3A240#combinations
- the unsearchable uses the same `fields+moreFields` as the main preset
- the `imageUrl` (https://github.com/ideditor/schema-builder/blob/main/schemas/preset.json#L62-L65) is the traffic sign from https://wiki.openstreetmap.org/wiki/DE:Tag:traffic_sign%3DDE:240
- the presets match on the two main tags and add the `addTags` or suggest to do so
- should a mapper switch the preset back to something else, `removeTags` should remove the special tags that the mapper should re-add manually
- the list of `fields+moreFields` are optimized for Germany: name move to moreFields (not commonly present on cycleways), segregated was added, sort order was changed for logical groups
- the cycleway with `highway=path`-preset it still in the cycleway-folder, to keep them together
---
 .../_cycleway-traffic-sign-DE-240.json        | 30 +++++++++++
 .../cycleway/path-traffic-sign-DE-240.json    | 50 +++++++++++++++++++
 2 files changed, 80 insertions(+)
 create mode 100644 data/presets/highway/cycleway/_cycleway-traffic-sign-DE-240.json
 create mode 100644 data/presets/highway/cycleway/path-traffic-sign-DE-240.json

diff --git a/data/presets/highway/cycleway/_cycleway-traffic-sign-DE-240.json b/data/presets/highway/cycleway/_cycleway-traffic-sign-DE-240.json
new file mode 100644
index 000000000..5d40273f4
--- /dev/null
+++ b/data/presets/highway/cycleway/_cycleway-traffic-sign-DE-240.json
@@ -0,0 +1,30 @@
+{
+    "locationSet": {
+        "include": ["DE"]
+    },
+    "icon": "fas-biking",
+    "imageURL": "https://upload.wikimedia.org/wikipedia/commons/0/08/Zeichen_240_-_Gemeinsamer_Fu%C3%9F-_und_Radweg%2C_StVO_1992.svg",
+    "fields": ["{highway/cycleway/path-traffic-sign-DE-240}"],
+    "moreFields": ["{highway/cycleway/path-traffic-sign-DE-240}"],
+    "geometry": ["line"],
+    "tags": {
+        "highway": "cycleway",
+        "traffic_sign": "DE:240"
+    },
+    "addTags": {
+        "bicycle": "designated",
+        "foot": "designated",
+        "segregated": "no"
+    },
+    "removeTags": {
+        "bicycle": "designated",
+        "foot": "designated",
+        "segregated": "no"
+    },
+    "terms": [],
+    "name": "Cycle & Foot Path (Traffic sign DE:240)",
+    "reference": {
+        "key": "traffic_sign",
+        "value": "DE:240"
+    }
+}
diff --git a/data/presets/highway/cycleway/path-traffic-sign-DE-240.json b/data/presets/highway/cycleway/path-traffic-sign-DE-240.json
new file mode 100644
index 000000000..a627477ce
--- /dev/null
+++ b/data/presets/highway/cycleway/path-traffic-sign-DE-240.json
@@ -0,0 +1,50 @@
+{
+    "locationSet": {
+        "include": ["DE"]
+    },
+    "searchable": false,
+    "icon": "fas-biking",
+    "imageURL": "https://upload.wikimedia.org/wikipedia/commons/0/08/Zeichen_240_-_Gemeinsamer_Fu%C3%9F-_und_Radweg%2C_StVO_1992.svg",
+    "fields": [
+        "surface",
+        "smoothness",
+        "segregated",
+        "access",
+        "oneway",
+        "width",
+        "structure",
+        "incline"
+    ],
+    "moreFields": [
+        "name",
+        "covered_no",
+        "dog",
+        "lit",
+        "maxspeed",
+        "maxweight_bridge",
+        "not/name",
+        "stroller",
+        "wheelchair"
+    ],
+    "geometry": ["line"],
+    "tags": {
+        "highway": "path",
+        "traffic_sign": "DE:240"
+    },
+    "addTags": {
+        "bicycle": "designated",
+        "foot": "designated",
+        "segregated": "no"
+    },
+    "removeTags": {
+        "bicycle": "designated",
+        "foot": "designated",
+        "segregated": "no"
+    },
+    "terms": [],
+    "name": "Cycle & Foot Path (Traffic sign DE:240)",
+    "reference": {
+        "key": "traffic_sign",
+        "value": "DE:240"
+    }
+}