Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

popular unsupported values of major keys #529

Open
matkoniecz opened this issue Jul 12, 2022 · 22 comments
Open

popular unsupported values of major keys #529

matkoniecz opened this issue Jul 12, 2022 · 22 comments

Comments

@matkoniecz
Copy link
Contributor

matkoniecz commented Jul 12, 2022

Based on taginfo - so some may be fixed already (I noticed and removed barrier=log). Some have open PRs already. Some would be wrong to include, some would require checking.

Generated with https://github.com/matkoniecz/taginfo_api_wrapper_in_python#listing-popular-tags-unsupported-by-id

It is usable for review. But using it requires some thinking. For example I like shop = estate_agent and is in my opinion preferable to office = estate_agent (as office=estate_agent and other office=* is used both for places inaccessible to general population such as internal offices - and for ones accessible to general population, but changing id presents requires some investigation what other mappers think).

Note that some highly used values, are from imports of a low quality. That would allow filtering out values discussed separately and/or rejected. Many values initially on this list were filtered out and skipped.

If that list is useful - then more systematic reviewing like JOSM is doing may be useful.

Other potential comparisons: list tags supported by JOSM or Vespucci and not supported by iD.

@tyrasd
Copy link
Member

tyrasd commented Jul 12, 2022

Thanks for compiling this list. I've marked off a few which have been recently added to the repository: highway=speed_display, highway=emergency_access_point and some of the barrier options.

@matkoniecz
Copy link
Contributor Author

matkoniecz commented Jul 12, 2022

added some issue links

barrier=handrail seems a good target for me.

barrier=debris 3k and power=catenary_mast 54k power=heliostat 18k looks like a niche but valid to include as far as I can see

highway=via_ferrata 2k seems a good idea, but likely should be verified with wider community

note: no significant research was done here

@danieldegroot2
Copy link
Contributor

@matkoniecz could you exclude power=abandoned:tower, please? It is obviously abandoned:power=tower.

@westnordost
Copy link
Contributor

Regarding shop=estate_agent 4k, would

  1. a PR to deprecate shop=estate_agent and "upgrade" to office=estate_agent be accepted?
  2. or, would a PR to add a non-searchable preset (to not promote, but understand it) for shop=estate_agent be accepted?

@matkoniecz
Copy link
Contributor Author

matkoniecz commented Oct 3, 2022

office=estate_agent has problem of mixing "place where actual clients can go and talk/actually buy real estate" and "internal office of company handling real estate, no entry for clients"

Second one would be better tagged office=company - maybe with company=real_estate

So can we avoid deprecation here?

@matkoniecz
Copy link
Contributor Author

I added listing for keys such as: craft, man_made, advertising, aeroway, boundary, emergency, cycleway (and its variants), historic, military, route, sport, healthcare (with some dubious popular values excluded)

And marked natural=crevasse as ignored, as it is basically import only

@danieldegroot2
Copy link
Contributor

From existing list;

@matkoniecz
Copy link
Contributor Author

edited

@hamishmb
Copy link

I'm an avid StreetCompleter, and end up creating notes for some of these things because there's not an in-app way to add them, or change them.

I think these cleanups are a good idea too - what does man_made = beam even mean anyway? Due to my autism, I probably get confused by these things more easily than some.

@arch0345
Copy link
Contributor

A preset for power=catenary_mast was added in #593

@arch0345
Copy link
Contributor

#649 added a preset for power=portal in addition to man_made=gantry

A preset for power=terminal was proposed in #653

A preset for emergency=dry_riser_inlet was proposed in #642

@matkoniecz
Copy link
Contributor Author

List updated.

@k-yle
Copy link
Collaborator

k-yle commented Dec 28, 2022

@matkoniecz irrigation=pivot isn't in the list, but it has 25k uses and presets in JOSM and Vespucci

@matkoniecz
Copy link
Contributor Author

@k-yle That is because this list has only popular values of "major keys" (due to technical limitations and to avoid need for vading through import debris)

Feel free top open a new issue for it if support for that tag is needed/useful.

@Dimitar5555
Copy link
Contributor

Dimitar5555 commented Feb 5, 2023

There is a field for all cycleway(:*) values except for cycleway:both which is tracked in #743.

man_made=gantry has also been added.

@matkoniecz
Copy link
Contributor Author

man_made=gantry has also been added.

marked

@matkoniecz
Copy link
Contributor Author

marked as done

@matkoniecz
Copy link
Contributor Author

cycleway:both which is tracked in #743.

marked

@matkoniecz
Copy link
Contributor Author

matkoniecz commented Mar 6, 2023

jdhoek added a commit to jdhoek/id-tagging-schema that referenced this issue Mar 9, 2023
jdhoek added a commit to jdhoek/id-tagging-schema that referenced this issue Mar 9, 2023
jdhoek added a commit to jdhoek/id-tagging-schema that referenced this issue Mar 9, 2023
jdhoek added a commit to jdhoek/id-tagging-schema that referenced this issue Mar 10, 2023
jdhoek added a commit to jdhoek/id-tagging-schema that referenced this issue Mar 10, 2023
jdhoek added a commit to jdhoek/id-tagging-schema that referenced this issue Mar 10, 2023
@matkoniecz
Copy link
Contributor Author

Maybe closing this issue and generating new one like this would be useful? (this will take me about 10 minutes, including time to move linked issues/PRs, so it is more question whether new one will be more useful)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants