Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Describe barrier=yes as "Unspecific barrier value" and complain about it in validator #531

Closed
matkoniecz opened this issue Jul 13, 2022 · 4 comments

Comments

@matkoniecz
Copy link
Contributor

matkoniecz commented Jul 13, 2022

triggered by https://www.openstreetmap.org/note/3264943

See also #399 ("Describe shop=yes as "Unspecific shop"")

@1ec5
Copy link
Contributor

1ec5 commented Jul 13, 2022

Note that “unspecified” is a more natural word than “unspecific”.

I’m not sure that there’s a readily available validator rule that could be defined in this repository for barrier=yes, unless you mean that this tag should be deprecated in favor of… something. I think there would need to be a change downstream in iD to implement a new validator rule for nonspecific tags, if it’s really so urgent to choose a tag other than barrier=yes. (From a routing standpoint, at least, a much more urgent task would be to set access tags. Routers don’t assume the default access tags that most mappers intuitively expect.)

@matkoniecz
Copy link
Contributor Author

barrier=yes is a valid tag to use and should not be deprecated, but replacing it with more specific values is very useful.

@tyrasd tyrasd added deprecating new-label changes the name, aliases or terms of a preset new-preset labels Jul 22, 2022
@tyrasd tyrasd closed this as completed in eba23b4 Jul 22, 2022
@tyrasd tyrasd removed deprecating new-label changes the name, aliases or terms of a preset labels Jul 22, 2022
@tyrasd
Copy link
Member

tyrasd commented Jul 22, 2022

ea34244 adds a preset for barrier=yes called Barrier (Unspecified Type) following the case of shop=yes in #399.

but replacing it with more specific values is very useful.

can you open a new feature request for a validator message on the iD repo, please?

@matkoniecz
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants