Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add language dropdown menu to My Preferences #4461

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AntonKhorev
Copy link
Collaborator

@AntonKhorev AntonKhorev force-pushed the preferences-language-dropdown branch from d5bbefa to fc255e1 Compare January 6, 2024 11:24
@tomhughes
Copy link
Member

There is some overlap here with #3618 which attempted to add a locale selector to the front page, only in as much as that if we did both we'd want to use the same selector in both places.

I've just rebased that on the current code (there's a live version at https://locale.apis.dev.openstreetmap.org/) but the styling of the selector is broken - think it's some conflict between bootstrap and the wikimedia styling of the language selector 😞

@AntonKhorev AntonKhorev force-pushed the preferences-language-dropdown branch from fc255e1 to ea429c1 Compare January 10, 2024 11:21
Copy link
Member

@tomhughes tomhughes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is adding new languages at the start the best choice? Won't most users add languages starting with their first choice and then moving to other languages they understand?

@AntonKhorev
Copy link
Collaborator Author

If a language is added at the end, a user may choose the language, press the Add button and expect the ui to switch to that language. But it's probably not going to happen because another language that was in the preferences before is also supported and still has higher priority.

@AntonKhorev
Copy link
Collaborator Author

Won't most users add languages starting with their first choice and then moving to other languages they understand?

Maybe, but I expect most users to pick only one language. If they want to pick several, they are probably used to editing strings with multiple language codes and they are not going to use the dropdown at all.

@AntonKhorev
Copy link
Collaborator Author

Maybe change the button label from "Add" to "Prepend"?

@AntonKhorev AntonKhorev added ui User Interface javascript Pull requests that update Javascript code labels Jul 3, 2024
@nertc nertc mentioned this pull request Aug 14, 2024
@nertc nertc mentioned this pull request Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code ui User Interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants