Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added preventing old oc versions to publish #113

Merged
merged 7 commits into from
Sep 24, 2015

Conversation

jankowiakmaria
Copy link
Collaborator

@matteofigus
Copy link
Member

Generally speaking is fine, I just would like a better error message, that specifies the registry version. Something like ... Upgrade OC CLI running [sudo] npm i -g oc@1.2.X. So ideally using the latest patch of the registry's minor version.

This is also for the future in order to prevent people from upgrading CLIs to versions that are actually behind the registry.

@matteofigus
Copy link
Member

Good job btw! 🍻

matteofigus added a commit that referenced this pull request Sep 24, 2015
Added preventing old oc versions to publish
@matteofigus matteofigus merged commit 34d1bfe into master Sep 24, 2015
@matteofigus matteofigus deleted the PreventOldOcToPublish branch September 24, 2015 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants