Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Oc client limited retries #144

Merged
merged 11 commits into from
Nov 23, 2015
Merged

Oc client limited retries #144

merged 11 commits into from
Nov 23, 2015

Conversation

pbazydlo
Copy link
Collaborator

Resolves: #136
Doesn't do exponential backoff.

  • Please verify if configuration params make sense.
  • When number of retries is exceeded nice error is shown and client stops retrying.
  • Retries are counted per component href.

@pbazydlo
Copy link
Collaborator Author

in test/front-end/ocTestConfig.js i set oc.conf.retryInterval = 1 so that retries happen very fast and can be reasonably tested, this is hooked up in test/configuration/karma-local.js so that the config is set before oc-client is loaded. it worked when running grunt test and grunt karma:local but it seems i missed something

@@ -0,0 +1,19 @@
'use strict';
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i pulled common configuration from karma-local and karma-sauce into a separate file

@pbazydlo
Copy link
Collaborator Author

@matteofigus passing now, as for running karma:sauce locally we could add karma:sauce-local task and install chrome driver, then we would be able to run it locally

@andyroyle
Copy link
Collaborator

looks good to me

andyroyle added a commit that referenced this pull request Nov 23, 2015
@andyroyle andyroyle merged commit 9d71b98 into master Nov 23, 2015
@andyroyle
Copy link
Collaborator

@matteofigus want me to publish?

@matteofigus
Copy link
Member

@andyroyle that would be cool. When in master, can you also add @pbazydlo here? https://github.com/opentable/oc/blob/master/README.md#contributors

@matteofigus matteofigus deleted the oc-client-limited-retries branch November 23, 2015 09:34
@pbazydlo
Copy link
Collaborator Author

yay

@andyroyle
Copy link
Collaborator

published in 0.20.1

@matteofigus
Copy link
Member

Thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants