add "getRepositoryUrl" in order to support repository package.json property as object #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
|
|
||
| component.getRepositoryUrl = function() { | ||
| if (typeof this.repository === 'object') { |
There was a problem hiding this comment.
can we just use underscore's _.isObject for consistency?
|
Grazie, looks good. Would you mind adding those 2 little adjustments + adding yourself as contributor? |
Fix travis forks PRs
matteofigus
added a commit
that referenced
this pull request
Mar 11, 2016
add "getRepositoryUrl" in order to support repository package.json property as object
|
Thanks good stuff! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As per the npm documentation https://docs.npmjs.com/files/package.json#repository the repository property inside the package.json file should be an object like the following:
{ "type": "git", "url": "https://github.com/npm/npm.git" }I added a getRepositoryUrl method against the component object that returns:
then in the view (the partial .jade file) the above method is used instead of the property itself.