Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog using git history instead of github api #212

Merged
merged 2 commits into from
Mar 22, 2016
Merged

Conversation

matteofigus
Copy link
Member

This is a replacement for the current Changelog generator. I spent a couple of hours trying all of them, they all seem over complicated for what we want to achieve here. Also, using github api is crazy as hundreds of requests are needed (repo details, one for each commit, one for each tag), and all we need is instead available using git.

This works. Future improvement is to separate this to its own grunt module, but seems good enough for now.

Can you review @pbazydlo or @jankowiakmaria ?

@pbazydlo
Copy link
Collaborator

lgtm, @matteofigus have you thought about putting that grunt task into public npm module?

pbazydlo added a commit that referenced this pull request Mar 22, 2016
Changelog using git history instead of github api
@pbazydlo pbazydlo merged commit b746f64 into master Mar 22, 2016
@pbazydlo pbazydlo deleted the changelog branch March 22, 2016 10:07
@matteofigus
Copy link
Member Author

lol, 👍

Future improvement is to separate this to its own grunt module

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants