Dependencies upgrade #254
Merged
Dependencies upgrade #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hi @matteofigus LGTM I also managed to fetch the repo and run all the tests; everything is green!
I am going to merge and delete this branch alright? -Mattia |
|
Sure go for it @mattiaerre |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to partially fix, short term, #252
Shrinkrapping all the nested dependencies seems a bit of a voodoo practice, but it is not uncommon.
Summary here:
Nested deps upgraded to latest version because of vulnerabilities:
PS - Targz has breaking changes. This means both Registry and CLI need to be in sync so this will require a minor version upgrade.