Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs cleanup #264

Merged
merged 2 commits into from
Jul 6, 2016
Merged

Docs cleanup #264

merged 2 commits into from
Jul 6, 2016

Conversation

matteofigus
Copy link
Member

@matteofigus matteofigus commented Jul 5, 2016

  • Docs moved to wiki
  • Logo image included inside the web interface
  • Removed CLI docs generation from build task (that is pretty consolidated now - but still left the autogen task in case we want to update the wiki in the future)
  • Wiki is already in place

Can you have a look @jankowiakmaria or @mattiaerre?

@matteofigus matteofigus changed the title Docs Docs cleanup Jul 5, 2016
@jankowiakmaria
Copy link
Collaborator

in general LGTM

According to wiki changes:

  • few page titles don't match titles from index (example: "Registry post route" vs "Batch endpoint") <- is it desired?
  • https://github.com/opentable/oc/wiki#components link doesn't work for me (it doesn't scroll to appropriate section of the page)
  • not sure if logo in the index is not too big:

image

Nothing major, only a few comments according wiki ^^ @matteofigus

@matteofigus
Copy link
Member Author

Thanks @jankowiakmaria

  • Yes, desired
  • Fixed
  • Reduced the logo

Can you merge when you're happy?

Thanks

@jankowiakmaria jankowiakmaria merged commit 6145399 into master Jul 6, 2016
@jankowiakmaria jankowiakmaria deleted the docs branch July 6, 2016 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants