[careful + breaking change] Removed Handlebars 3 support #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this could be kind of ready if you want to start doing a review @antwhite / @mattiaerre? |
| } else if(compiledViewInfo.type === 'jade'){ | ||
| oc.require('jade', JADE_URL, function(jade){ | ||
| oc.require('jade', JADE_URL, function(){ |
There was a problem hiding this comment.
this is not related right? you just removed the parameter as not used by that function correct? a.k.a. "the boy scout rule" 😄
|
not sure how it works w/ licenses but what about this? https://github.com/opentable/oc/blob/handlebars4/src/components/oc-client/LICENSES#L80 |
| @@ -37,24 +37,14 @@ describe('oc-client : render', function(){ | |||
| var originalHb3, originalHb4; | |||
There was a problem hiding this comment.
I think we do not need these variables anymore do we?
There was a problem hiding this comment.
Ok I cleaned up this
|
LGTM |
|
Thanks! So, @mattiaerre can you merge when you're happy about the tests? (I added some as requested). |
| @@ -32,4 +32,43 @@ describe('client : validator', function(){ | |||
| }); | |||
| }); | |||
| }); | |||
|
|
|||
| describe('when validating component', function(){ | |||
|
good job @matteofigus // cc @antwhite |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the last PR for fixing #252 - following #243