Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server-side nested rendering #270

Merged
merged 11 commits into from
Jul 20, 2016
Merged

server-side nested rendering #270

merged 11 commits into from
Jul 20, 2016

Conversation

matteofigus
Copy link
Member

@matteofigus matteofigus commented Jul 15, 2016

Fixes #224

The plan is to expose in the context object 2 new methods, similar to the node.js client:

context.renderComponent(componentName [, options], callback)

with options containing optional params parameters, headers, version and callback with a signature of (error, html)

context.renderComponents(components [, options], callback)

with components array of objects containing mandatory name and optional version and parameters
and options containing optional params headers and callback with a signature of (error, html)

@matteofigus matteofigus changed the title First go at server-side nested rendering server-side nested rendering Jul 15, 2016
@matteofigus matteofigus removed the wip label Jul 18, 2016
@jankowiakmaria
Copy link
Collaborator

LGTM but I think I'd like to be added:

  • more unit tests for rendering multiple components (currently it's always one in tests with nestedRenderer.renderComponents) with and without component specific and shared parameters,
  • and acceptance test for renderComponents (currently there is one for renderComponent)

@matteofigus
Copy link
Member Author

Ok @jankowiakmaria I'll work on that - thanks!

@jankowiakmaria
Copy link
Collaborator

LGTM, merging

@jankowiakmaria jankowiakmaria merged commit 7fa15dc into master Jul 20, 2016
@jankowiakmaria jankowiakmaria deleted the server-nesting branch July 20, 2016 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants