npm install and dep resolvement needs to happen in the same dir #285
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two issues:
oc dev componentsFolder
. Basically, until now npm install was installing inside components folder, and dependency were resolved on the folder theoc dev
was running. So,oc dev .
was always working (so, when launching the dev inside the components folder) butoc dev componentsFolder
wasn't. From now, with this fix, it is decided that npm dependencies are installed in anode_modules
folder relative to theoc dev
and that's where they are resolved. This should make the dev watcher able to run from both locations.The easiest way to test this stuff is to use a folder of components using dependency and manually run the acceptance tests from various locations. We can also add extra unit testing but I am not too concerned as this is mostly a CLI minor feature and shouldn't have impact on a registry.
@lobut let's have a look at this together tomorrow so that we can do some manual testing together and then merge ;)