Client#renderComponents accepts global parameters #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matteofigus
reviewed
Oct 11, 2016
| @@ -246,7 +351,8 @@ describe('The node.js OC client', function(){ | |||
| components: [{ | |||
| name: 'hello-world', | |||
| version: '~1.0.0' | |||
| }] | |||
| }], | |||
| parameters: {} | |||
There was a problem hiding this comment.
uhm, why an empty parameters here? Just to test you can pass an empty object and that still works?
There was a problem hiding this comment.
it's because of the way renderComponent works (https://github.com/opentable/oc/blob/master/client/src/index.js#L26-L43). It uses renderComponents behind the scenes (which by default passes empty object as global parameters) - that's why expectedRequest contains parameters.
In case of the other two tests - the same thing, we're using renderComponents and in options (for renderComponent) we pass parameters which means they become global in internal renderComponents call.
| }], | ||
| parameters: { | ||
| hi: 'john' | ||
| } |
There was a problem hiding this comment.
I guess same reason here (2)
| parameters: { | ||
| errorType: 'timeout', | ||
| timeout: 1000 | ||
| } |
|
Thanks, excellent! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #185