Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring, cleanup, test coverage #311

Merged
merged 6 commits into from
Oct 21, 2016
Merged

Refactoring, cleanup, test coverage #311

merged 6 commits into from
Oct 21, 2016

Conversation

matteofigus
Copy link
Member

@matteofigus matteofigus commented Oct 20, 2016 •
edited
Loading

This is many changes, still looking at each commit separately should hopefully makes sense for the review.

@matteofigus matteofigus changed the title [wip] Refactoring, cleanup, test coverage Refactoring, cleanup, test coverage Oct 20, 2016
@matteofigus matteofigus removed the wip label Oct 20, 2016
jwhayes
jwhayes approved these changes Oct 21, 2016
View reviewed changes
Copy link
Contributor

@jwhayes jwhayes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matteofigus matteofigus merged commit fb8fca4 into master Oct 21, 2016
@matteofigus matteofigus deleted the registry-start-timeout branch October 21, 2016 10:20
@matteofigus matteofigus mentioned this pull request Oct 21, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwhayes jwhayes jwhayes approved these changes

Assignees
No one assigned
Labels
Registry's API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matteofigus @jwhayes