Webpack 2 #357
Merged
Webpack 2 #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nickbalestra
commented
Jan 19, 2017
•
nickbalestra
commented
- [GPT-432] Package server webpack #346 Need to be merged first then we can rebase and add this in.
nickbalestra
force-pushed
the
webpack2
branch
from
eee71b6
to
6d64aac
Compare
|
@nickbalestra I merged the other one. Can you rebase this? Cheers |
nickbalestra
force-pushed
the
webpack2
branch
from
6d64aac
to
9cf0a35
Compare
nickbalestra
commented
Jan 21, 2017
| @@ -65,7 +65,6 @@ | |||
| "handlebars": "4.0.5", | |||
| "infinite-loop-loader": "1.0.0", | |||
| "jade": "1.11.0", | |||
| "json-loader": "0.5.4", | |||
There was a problem hiding this comment.
| @@ -84,6 +83,6 @@ | |||
| "uglify-js": "2.6.4", | |||
| "underscore": "1.8.3", | |||
| "watch": "0.19.1", | |||
| "webpack": "1.14.0" | |||
| "webpack": "2.2.0" | |||
There was a problem hiding this comment.
If this version is not visible on npm, is cause it still behind the beta flag. Reason for this choice by the wp team is to speed up writing documentation. They will remove the beta flag once documentation is fully complete. But webpack itself is totally out of beta and stable
| var injectr = require('injectr'); | ||
| var path = require('path'); | ||
| var sinon = require('sinon'); | ||
| var uglifyJs = require('uglify-js'); |
There was a problem hiding this comment.
extra cleanup of unneded require for the new updated unit test.
matteofigus
approved these changes
Jan 21, 2017
| "resolved": "https://registry.npmjs.org/webpack/-/webpack-1.14.0.tgz" | ||
| "version": "2.2.0", | ||
| "from": "webpack@2.2.0", | ||
| "resolved": "https://registry.npmjs.org/webpack/-/webpack-2.2.0.tgz" |
| }] | ||
| ] | ||
| }) | ||
| use: [ |
There was a problem hiding this comment.
I really like the new syntax. Much cleaner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.