Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Express 4 #366

Merged
merged 7 commits into from
Jan 30, 2017
Merged

Express 4 #366

merged 7 commits into from
Jan 30, 2017

Conversation

matteofigus
Copy link
Member

@matteofigus matteofigus commented Jan 23, 2017 •
edited
Loading

Fixes #321

https://expressjs.com/en/guide/migrating-4.html

  • Migrate to express 4
  • NPM shrinkwrap voodoo
  • All tests green
  • All warnings removed
  • Manual testing done on components execution
  • Manual testing on the logger
  • Manual testing done on components publish
  • Some performance comparison between versions

@matteofigus matteofigus self-assigned this Jan 23, 2017
@matteofigus
Copy link
Member Author

I did some benchmarking locally with real heavy components and express 4 seems to be 1.9% quicker 👍

@matteofigus matteofigus changed the title [wip] Express 4 Express 4 Jan 23, 2017
@matteofigus matteofigus removed the wip label Jan 23, 2017
@matteofigus
Copy link
Member Author

All tested locally and works nicely. To you for reviewing if you can @nickbalestra

nickbalestra
nickbalestra approved these changes Jan 24, 2017
View reviewed changes
Copy link
Contributor

@nickbalestra nickbalestra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@matteofigus matteofigus removed the wip label Jan 30, 2017
@matteofigus
Copy link
Member Author

I am now merging this.

@matteofigus matteofigus merged commit 1a03e69 into master Jan 30, 2017
@matteofigus matteofigus deleted the express branch January 30, 2017 11:24
@matteofigus matteofigus mentioned this pull request Mar 8, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickbalestra nickbalestra nickbalestra approved these changes

Assignees

@matteofigus matteofigus

Labels
Registry's API required / technical debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matteofigus @nickbalestra