oc-template-handlebars module #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nickbalestra
commented
Jan 25, 2017
•
nickbalestra
commented
- To be reviewed/rebased once https://github.com/opentable/oc-template-handlebars v1.0.0 has been published
added 4 commits
January 30, 2017 12:42
…edTemplate method
nickbalestra
force-pushed
the
oc-template-handlebars
branch
2 times, most recently
from
dd9867b
to
bfa54f7
Compare
matteofigus
reviewed
Jan 30, 2017
| @@ -3926,42 +3926,6 @@ | |||
| } | |||
| } | |||
| }, | |||
| "handlebars": { | |||
There was a problem hiding this comment.
This is gonna break node 7. You need complete dep tree. Basically you can just add "dependencies" to "oc-template-handlebars" and nest this snippet here
nickbalestra
force-pushed
the
oc-template-handlebars
branch
from
bfa54f7
to
a8b5618
Compare
nickbalestra
changed the title
|
Another little thing @nickbalestra - can you update oc-client's package.json too? (that is only the package.json, we got rid of the shrinkwrap there) |
|
Excellent. This is a great foundation for modular templates 👍 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.