oc-template-jade module #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickbalestra
changed the title
nickbalestra
force-pushed
the
oc-template-jade
branch
from
5367fb3
to
5ef251b
Compare
matteofigus
requested changes
Jan 31, 2017
src/cli/domain/package-template.js
Outdated
| compileDebug: false, | ||
| name: 't' | ||
| }).toString().replace('function t(locals) {', 'function(locals){'); | ||
| preCompiledView = jade.precompile(template, { filename: viewPath }); |
There was a problem hiding this comment.
I think I would like to do something similar to the oc-client here rather than all the ifs. Something like
var precompilers = { jade, handlebars};
// and then
if(!precompilers[type]){
throw strings.errors.cli.TEMPLATE_TYPE_NOT_VALID;
}
var preCompiledView = precompilers[type].precompile(template, { viewPath });There was a problem hiding this comment.
Also, note that in jade we named that viewPath, not filename 👍
| var context = { jade: require('jade/runtime.js')}; | ||
| vm.runInNewContext(templateText, context); | ||
| template = context.oc.components[key]; | ||
| template = jade.getPrecompiledTemplate(templateText, key); |
|
Updated. |
matteofigus
requested changes
Jan 31, 2017
|
Should be fixed now |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done per jade what we did for handlebars in #371
To be rerun once oc-template-jade will be published