Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup un-needed files #376

Merged
merged 3 commits into from
Feb 1, 2017
Merged

Cleanup un-needed files #376

merged 3 commits into from
Feb 1, 2017

Conversation

matteofigus
Copy link
Member

We forgot this on previous PR #375

Copy link
Contributor

@nickbalestra nickbalestra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gr8 job, just a small thing for consistency

var settings = require('./settings');
var TryGetCached = require('./try-get-cached');

module.exports = function(cache){

var renderers = {
Copy link
Contributor

@nickbalestra nickbalestra Feb 1, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Used templateEngines instead of renderers, I think will be better if we try to stick to the same name convention

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@nickbalestra nickbalestra merged commit d808833 into master Feb 1, 2017
@nickbalestra nickbalestra deleted the cleanup branch February 1, 2017 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants