Make oc-client.js supporting more templates via an extendable API #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickbalestra
force-pushed
the
oclient-templates
branch
from
78077ff
to
e3ad23e
Compare
matteofigus
requested changes
Mar 8, 2017
| @@ -294,25 +310,35 @@ var oc = oc || {}; | |||
|
|
|||
| oc.render = function(compiledViewInfo, model, callback){ | |||
| oc.ready(function(){ | |||
| if(!!compiledViewInfo.type.match(/jade|handlebars/g)){ | |||
|
|
|||
| var template = templates.find(function(template){return template.type === compiledViewInfo.type}); | |||
There was a problem hiding this comment.
find is not supported in IE: https://developer.mozilla.org/en/docs/Web/JavaScript/Reference/Global_Objects/Array/find
Perhaps we can use something available in jQuery?
There was a problem hiding this comment.
I'll go vanilla, no need for a $ dependency just for that in here imho.
nickbalestra
force-pushed
the
oclient-templates
branch
from
e3ad23e
to
5704b5f
Compare
matteofigus
approved these changes
Mar 19, 2017
|
This is fantastic, thanks @nickbalestra |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make oc-client.js supporting more templates other then jade and handlebars (oc-template-react,..) through an API that allows to extend such support.
Context: The Api need to be able to register the new type of template supported and its various requirements (dependecies,..) Internally the architecture should take care of hadnling all the aspects needed in order to be able to render the new type of components (i.e: oc-template-react).
pre-configuration API:
post-configuration API: