Changed option parser for cli #399
Conversation
src/cli/commands.js
Outdated
|
|
||
| dev: { | ||
| help: 'Runs a local oc test registry in order to develop and test components', | ||
| cmd: 'dev <dirName> [port] [baseUrl]', //should be dirPath imho |
There was a problem hiding this comment.
agree, it should be dirPath
| hotReloading: { | ||
| boolean: true, | ||
| description: 'Enables hot reloading. Note: when hot reloading is set to true, each request to the component will make the registry to create a new instance for the javascript closures to be loaded, while when false the instance will be recycled between components executions', | ||
| default: true |
There was a problem hiding this comment.
As I've mentioned in PR comment - we can either have a positional argument or an option - yargs is really good but it offers different set of features than nomnom (it currently doesn't support description of positional arguments - I've seen workarounds to support it but they're not great)
There was a problem hiding this comment.
Sorry I totally forgot to read your first PR description. This is fine, sorry :)
src/cli/commands.js
Outdated
| }, | ||
|
|
||
| init: { | ||
| help: 'Creates a new empty component in the current folder', | ||
| cmd: 'init <componentName>', |
There was a problem hiding this comment.
shouldn't this be init <componentName> [templateType] ?
There was a problem hiding this comment.
as above - if you'd like to I can walk you through differences (I've tried to include everything in the PR comment).
There was a problem hiding this comment.
templateType used to be a positional arg https://github.com/opentable/oc/wiki/Cli#init so I think I would like to keep it as is (here you are basically changing it to be an option)
There was a problem hiding this comment.
fine for me :) will change it
in nomnom you could use it as either of them [positional argument/option] - it would work anyway.
| @@ -89,6 +87,7 @@ | |||
| "uglify-js": "2.6.4", | |||
| "underscore": "1.8.3", | |||
| "watch": "0.19.1", | |||
| "webpack": "2.2.0" | |||
| "webpack": "2.2.0", | |||
| "yargs": "^6.6.0" | |||
There was a problem hiding this comment.
let's pair on the shrinkwrap
|
@jankowiakmaria ok all good, only thing is on the oc init |
|
Amazing! Are you able to update the wiki @jankowiakmaria ? |
|
yep, sure :) |
resolves #135
Differences:
versioncommand (it hasversionoption instead)Question - should I shrinkwrap or is it done during publishing/at some other point of the process?