Fix ui preview with multiple discover strategies and endpoints #413
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #369
More in details, here is the reproduction steps.
Currently, when accessing the private instance's UI on a component page, preview's Iframe URL is set to
~preview
, which works, but the URL on the preview bar is set on baseURL, which means hitting Refresh is gonna hit the public url with discovery: false, and the preview is not gonna be visible.With this fix, we set the URL on the preview bar based on the current host, which means hitting Refresh is gonna hit the correct page with discovery: true.
I tested this locally by using some host entries and it works fine.
/cc @mattiaerre @chriscartlidge