New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider null a valid string #446

Merged

federicomaffei merged 2 commits into master from nullstring

Apr 7, 2017

Member

matteofigus commented Apr 7, 2017

Fixes #425

I decided to proceed in the following way:

When a string null parameter gets sent to the request, it gets first parsed for applying default values. Before, it used to apply a default in case of undefined => now it applies default in case of null too.
After applying the default values, if any, there is a sanitisation process. If the string param is still null I sanitise it by converting it to empty string
Validation will be ok in case of empty.

I included some unit tests and also an acceptance that tests that too.

matteofigus added 2 commits

April 7, 2017 14:58


          Consider null a valid string

9703f56


          Cleanup

d2cb325

federicomaffei approved these changes

View reviewed changes

Collaborator

federicomaffei left a comment

👍

federicomaffei merged commit 7d80a11 into master

matteofigus deleted the nullstring branch

April 7, 2017 16:45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet