Components by dir cleanup #447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matteofigus
commented
Apr 7, 2017
| return false; | ||
| } | ||
| try { | ||
| content = fs.readJsonSync(packagePath); |
There was a problem hiding this comment.
Previous behaviour was to check dir existed, check package.json existed, and then trying to read. For simplicity, let's just try to read the Json in that folder. If it's a component, it will be there. If it's not, let's skip the dir.
matteofigus
commented
Apr 7, 2017
| } catch(err){ | ||
| return callback(err); | ||
| return callback(null, []); |
There was a problem hiding this comment.
if the dir can't be read because is protected or doesn't exist, let's just say we didn't find anything.
matteofigus
commented
Apr 7, 2017
| @@ -11,8 +11,7 @@ var packageComponents = require('./package-components'); | |||
| var mock = require('./mock'); | |||
| var validator = require('../../registry/domain/validators'); | |||
|
|
|||
| module.exports = function(dependencies){ | |||
| var logger = dependencies.logger; | |||
| module.exports = function(){ | |||
There was a problem hiding this comment.
no way logger should be exposed outside of CLI facades...
matteofigus
commented
Apr 7, 2017
| callback(err); | ||
| return log.err(err); | ||
| } else if(_.isEmpty(components)){ | ||
| if(_.isEmpty(components)){ |
There was a problem hiding this comment.
This won't error anymore. In case no components are found, it will yield (null, [])
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See inline comments.