Fix vulnerabilities and remove npm shrinkwrap #497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickbalestra
reviewed
Jun 1, 2017
| @@ -68,7 +68,8 @@ | |||
| "form-data": "0.1.4", | |||
| "fs-extra": "0.30.0", | |||
| "infinite-loop-loader": "1.0.1", | |||
| "jade": "1.11.0", | |||
| "jstransformer-clean-css": "^2.0.0", | |||
| "jstransformer-uglify-js": "^1.2.0", | |||
There was a problem hiding this comment.
As I don't know much about those libraries, where/how do those helpers being registered/used? (I guess you using the clean-css here, but couldn't find other references to those in the PR)
There was a problem hiding this comment.
Jade has bultin transformers for uglify-js and clean-css. With Pug, they modularised all the tranformers and you need to install all the transformers you want to use separately. That's why I had to include them. Also, 'uglify-css' has been renamed to 'clean-css'.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #404 and addresses a little bit of #298 (jade to pug migration is internal, but still not supported by templates).
After this upgrades, Snyk should go green so the shinkwrap should be not required anymore.