Show available dependencies in the UI #500
Conversation
There was a problem hiding this comment.
over to you @matteofigus I think this is a very nice step; I am wondering if we can expose this info as an API as well; something like: GET /api/v1/dependencies
| p.release #{dependency.name} (node.js core dependency) | ||
| else | ||
| p.release #{dependency.name}@#{dependency.version} | ||
|
|
There was a problem hiding this comment.
Good catch @mattiaerre , what you think of adding prettier in the near future so that we don't have much nits anymore
There was a problem hiding this comment.
I'd love to have that @nickbalestra 👍
| each dependency in availableDependencies | ||
| .componentRow.row.table | ||
| a(href=dependency.link, target="_blank") | ||
| if dependency.core |
There was a problem hiding this comment.
do you think we should list core dependencies?
There was a problem hiding this comment.
Core deps are subject to be whitelisted too, so I think it's useful to show them. You can see 'url' in the screenshot example
There was a problem hiding this comment.
ok, I see. I thought they were implicitly available for us 😊
|
Happy to approve if you answer my main question here: thanks! // cc @matteofigus @nickbalestra |
|
@mattiaerre I would be ok on having an api endpoint for that, but I would leave it to a separate PR. Perhaps we can open an issue first to discuss, as I have opinions to discuss in regards of versioning, the url structure, authentication, and the endpoint scope (one for deps? or one generic with all the details)? |
|
@matteofigus very good then, as @corlobepy and I would like to work on a list of plugins as well and I was more inclined to expose them via an API so I was thinking that maybe we can have an API endpoint for deps as well. are you happy if we create a couple of issues and PRs on this particular subject? thanks |
|
Sure let's create an issue and discuss there ;) |
Fixes #490
Each dependency will be linked to either the package homepage or the node docs page (in case of core dependency).