Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop node4 tests #542

Merged
merged 2 commits into from
Jul 13, 2017
Merged

Drop node4 tests #542

merged 2 commits into from
Jul 13, 2017

Conversation

nickbalestra
Copy link
Contributor

Context: The node client has been moved out to his own repo and it still support node4. This allows us to now drop support for node4 on the cli/registry where we support >=6

Fixes #437

Copy link
Member

@matteofigus matteofigus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a deprecation notice on the cli for the node 4 dropped support

@nickbalestra
Copy link
Contributor Author

If run on node below v6 the following alert will be displayed in the terminal (example running 4.8.3):

ALERT: You're currently running OC on an unsupported Node version (v4.8.3).
Please upgrade Node to >= 6.0.0.

@matteofigus matteofigus merged commit 1da7ebb into master Jul 13, 2017
@matteofigus matteofigus deleted the dropNode4Support branch July 13, 2017 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants