Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OC-86] Logging href, renderMode on the component-retrieved events #580

Merged
merged 1 commit into from
Jul 28, 2017

Conversation

matteofigus
Copy link
Member

In case of error, the component-retrieved event was being fired without href and renderType, which are information we want to clearly log.

Copy link
Contributor

@nickbalestra nickbalestra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nickbalestra nickbalestra merged commit 968e50f into master Jul 28, 2017
@nickbalestra nickbalestra deleted the logging-all-fields branch July 28, 2017 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants