Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto install modules #60

Merged
merged 11 commits into from
Apr 30, 2015
Merged

Auto install modules #60

merged 11 commits into from
Apr 30, 2015

Conversation

andyroyle
Copy link
Collaborator

Turned out to be a bit wider scope than I thought, there are two bits to this:

  1. Ensuring that modules which are required are listed in package.json

During the package stage, when identifying local requires, we can also identify modules which are required. Once we have this list we can compare it to the package.json file and throw an error if they are missing.

  1. Because we know that all modules required by a component are listed in the package.json, we can read this and install any that aren't in the registry's node_modules folder

A by-product of doing (1) means that if we want to check whether a component requires modules that are not allowed by the server, it is easy to do so at publish-time.

@matteofigus
Copy link
Member

Wow!
Let me have a look at everything and I'll try to merge it today.

matteofigus added a commit that referenced this pull request Apr 30, 2015
@matteofigus matteofigus merged commit 87072be into master Apr 30, 2015
@matteofigus matteofigus deleted the auto-install-modules branch April 30, 2015 21:47
@matteofigus
Copy link
Member

This fixes #36

@andyroyle
Copy link
Collaborator Author

👍 awesome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants