Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass option to the compiler for targeting specific build process #613

Merged
merged 3 commits into from
Aug 30, 2017

Conversation

nickbalestra
Copy link
Contributor

@nickbalestra nickbalestra commented Aug 26, 2017

The following PR will pass an option to the compiler called build.

  • when running the cli dev build value is automatically set to development (can be override if needed by passing the flag -P when running the cli)
  • when running package or publish build is automatically set to production (and cannot be oveririden)

This will allow for template that support this to avoid complex processes like minifications, in order to offer a faster feedback-loop while developing #components and allow to enable more complex debugging tools like full sourcemaps, or react dev tools.

@nickbalestra nickbalestra changed the title Pass option to the compiler for better targeting process Pass option to the compiler for targeting build process Aug 26, 2017
@nickbalestra nickbalestra changed the title Pass option to the compiler for targeting build process Pass option to the compiler for targeting specific build process Aug 26, 2017
Copy link
Member

@matteofigus matteofigus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, I think I prefer something like production=true|false as this is more clear. Same for the cli param that I would document.

@matteofigus matteofigus merged commit e64ccbe into master Aug 30, 2017
@matteofigus matteofigus deleted the optimizeBuild branch August 30, 2017 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants