Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve watching for Dev registry #632

Merged
merged 2 commits into from
Sep 15, 2017
Merged

Improve watching for Dev registry #632

merged 2 commits into from
Sep 15, 2017

Conversation

nickbalestra
Copy link
Contributor

@nickbalestra nickbalestra commented Sep 8, 2017 •
edited
Loading

This PR addresses #351:

  • when on dev mode, only the component that was changed get re-compiled, not all the components. This should reduce feedback-loop times quite a bit when working in projects containing more components.
  • ignored files/dirs are now fully ignored from the tree of files to watch

Because of the combination of the two points above most of the reported issues should be address without the need for the user to explicitly define an ignore list.

@nickbalestra nickbalestra mentioned this pull request Sep 8, 2017
Closed
@nickbalestra nickbalestra changed the title Package only the affected component Improve watching for Dev registry Sep 9, 2017
@nickbalestra nickbalestra force-pushed the packageOnlyChanged branch 3 times, most recently from 28ff566 to d65f9db Compare September 9, 2017 13:07
@nickbalestra nickbalestra mentioned this pull request Sep 9, 2017
Merged
matteofigus
matteofigus requested changes Sep 14, 2017
View reviewed changes
Copy link
Member

@matteofigus matteofigus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - can you just rebase from master (I merged the livereload PR and there are conflicts)?
Then I think this will be ready to go

@nickbalestra
Copy link
Contributor Author

Awesome, sure thing!

@nickbalestra
Copy link
Contributor Author

@matteofigus rebased

@matteofigus matteofigus merged commit 0933a7f into master Sep 15, 2017
@matteofigus matteofigus deleted the packageOnlyChanged branch September 15, 2017 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matteofigus matteofigus matteofigus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nickbalestra @matteofigus