liveReload #635
liveReload #635
Conversation
| @@ -21,7 +27,8 @@ function componentPreview(err, req, res, component, templates) { | |||
| dependencies: _.keys(component.dependencies), | |||
| href: res.conf.baseUrl, | |||
| qs: urlBuilder.queryString(req.query), | |||
| templates: templates | |||
| templates, | |||
| liveReload | |||
| @@ -12,3 +12,4 @@ html | |||
| oc.conf.templates = oc.conf.templates || []; | |||
| oc.conf.templates = oc.conf.templates.concat(!{JSON.stringify(templates)}); | |||
| script(src=baseUrl+'oc-client/client.js') | |||
| | !{liveReload} | |||
There was a problem hiding this comment.
What about when this view is used in the UI? Should we put this here (with a localhost url) only if the registry is on local mode?
There was a problem hiding this comment.
I'm doing that here -> https://github.com/opentable/oc/pull/635/files#diff-e4f8fa94a02abcf0d568f89a410ab48eR16 (if that view is used on the UI when the registry is not on local mode, nothing is printed)
| @@ -43,7 +44,9 @@ module.exports = function(dependencies) { | |||
| if (!hotReloading) { | |||
| logger.warn(strings.messages.cli.HOT_RELOADING_DISABLED); | |||
| } else { | |||
| cb(components); | |||
| cb(components, done => { | |||
| liveReloadServer.refresh('/'); | |||
There was a problem hiding this comment.
how do you pick this url? /?
There was a problem hiding this comment.
The refresh method need you pass a string for the file that was changed. In our case for the moment that's not relevant so I'm passing some dummy content / to simply refresh the listening view (in our case the preview).
(In the future we might co-ordinate livereload to work more closely with out browser-client so that we could perform some sort of hot-reloading. For example immagine using this with the chrome-extension tool to just re-render that specific component...)
|
@matteofigus updated/commented |
nickbalestra
force-pushed
the
liveReload
branch
from
1166880
to
43470a3
Compare
liveReload feature on the registry when in DEV mode
As per #351