Error publish #700
Merged
Error publish #700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@matteofigus I'll leave it to you to release a new version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #696
I double checked the s3 error API: http://docs.aws.amazon.com/AWSJavaScriptSDK/latest/AWS/Response.html#error-property and added a test to fix the issue.
When we were using
give-meinstead ofasyncthe error could be an array: https://github.com/opentable/oc/blob/43841cd446b01975bee204941ce66399cb5899ed/registry/domain/s3.js#L109 but the putDir method in s3 is now the result of anasync.eachwhich returns the first error that encounters.