[DX-202] Execute all the tests #704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So, there are many other bugs. I think this PR attempts to fix the testing part and the build part (build needs to happen before the tests). The Changelog generation connected to the version tasks seems not to work and I'll follow up with a fix in another PR |
mattiaerre
approved these changes
Oct 9, 2017
| @@ -29,3 +29,5 @@ src/components/base-component-jade/_package | |||
|
|
|||
| test/fixtures/test.tar.gz | |||
| test/fixtures/targz-test | |||
|
|
|||
| logintervals.md | |||
| "patch": "node tasks/version.js --type=\"patch\"", | ||
| "major": "npm run version-major && npm run test-silent && npm run git-stage", | ||
| "minor": "npm run version-minor && npm run test-silent && npm run git-stage", | ||
| "patch": "npm run version-patch && npm run test-silent && npm run git-stage", |
There was a problem hiding this comment.
you can also use the native npm version <update_type> to update version on npm btw
There was a problem hiding this comment.
This is a bit different as it updates the oc-client component's version too - so that it matches the oc version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug introduced on #659 - the promise was resolved on the first file, not making all the tests to be correctly executed.