Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

specify registry from terminal #74

Merged
merged 2 commits into from
May 14, 2015
Merged

specify registry from terminal #74

merged 2 commits into from
May 14, 2015

Conversation

tpgmartin
Copy link

Fixes #70

@matteofigus
Copy link
Member

Hey Tom, thanks for the PR, try running grunt jshint, looks like there is a jshint problem. Try also grunt test-local to ensure jshint and tests are all green

@tpgmartin
Copy link
Author

@matteofigus jshint fails at line 41 of cli/facade/ls.js, with message "Possible strict violation." referring to use of 'this'. How do I correct it?

@matteofigus
Copy link
Member

Well done, thanks!

matteofigus added a commit that referenced this pull request May 14, 2015
@matteofigus
Merge pull request #74 from opentable/optionalRegistryParameter
3a0a615 
specify registry from terminal
@matteofigus matteofigus merged commit 3a0a615 into master May 14, 2015
@matteofigus matteofigus deleted the optionalRegistryParameter branch May 14, 2015 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

'oc ls' optionally specify registry via command line param
2 participants
@tpgmartin @matteofigus