update bittensor/core/extrinsics/transfer.py unit tests

Author: Roman

tests/unit_tests/extrinsics/test_transfer.py

@@ -1,142 +1,47 @@
-import pytest
+from bittensor.core.extrinsics import transfer
 
-from bittensor.core import subtensor as subtensor_module
-from bittensor.core.extrinsics.transfer import do_transfer
-from bittensor.core.subtensor import Subtensor
-from bittensor.utils.balance import Balance
 
+def test_transfer_extrinsic(mocker):
+    """Verify that sync `transfer_extrinsic` method calls proper async method."""
+    # Preps
+    fake_subtensor = mocker.Mock()
+    fake_wallet = mocker.Mock()
+    dest = "hotkey"
+    amount = 1.1
+    transfer_all = True
+    wait_for_inclusion = True
+    wait_for_finalization = True
+    keep_alive = False
 
-@pytest.fixture
-def subtensor(mocker):
-    fake_substrate = mocker.MagicMock()
-    fake_substrate.websocket.sock.getsockopt.return_value = 0
-    mocker.patch.object(
-        subtensor_module, "SubstrateInterface", return_value=fake_substrate
-    )
-    return Subtensor()
-
-
-def test_do_transfer_is_success_true(subtensor, mocker):
-    """Successful do_transfer call."""
-    # Prep
-    fake_wallet = mocker.MagicMock()
-    fake_dest = "SS58PUBLICKEY"
-    fake_transfer_balance = Balance(1)
-    fake_wait_for_inclusion = True
-    fake_wait_for_finalization = True
-
-    subtensor.substrate.submit_extrinsic.return_value.is_success = True
-
-    # Call
-    result = do_transfer(
-        subtensor,
-        fake_wallet,
-        fake_dest,
-        fake_transfer_balance,
-        fake_wait_for_inclusion,
-        fake_wait_for_finalization,
-    )
-
-    # Asserts
-    subtensor.substrate.compose_call.assert_called_once_with(
-        call_module="Balances",
-        call_function="transfer_allow_death",
-        call_params={"dest": fake_dest, "value": fake_transfer_balance.rao},
-    )
-    subtensor.substrate.create_signed_extrinsic.assert_called_once_with(
-        call=subtensor.substrate.compose_call.return_value, keypair=fake_wallet.coldkey
-    )
-    subtensor.substrate.submit_extrinsic.assert_called_once_with(
-        subtensor.substrate.create_signed_extrinsic.return_value,
-        wait_for_inclusion=fake_wait_for_inclusion,
-        wait_for_finalization=fake_wait_for_finalization,
-    )
-    subtensor.substrate.submit_extrinsic.return_value.process_events.assert_called_once()
-    assert result == (
-        True,
-        subtensor.substrate.submit_extrinsic.return_value.block_hash,
-        None,
-    )
-
-
-def test_do_transfer_is_success_false(subtensor, mocker):
-    """Successful do_transfer call."""
-    # Prep
-    fake_wallet = mocker.MagicMock()
-    fake_dest = "SS58PUBLICKEY"
-    fake_transfer_balance = Balance(1)
-    fake_wait_for_inclusion = True
-    fake_wait_for_finalization = True
-
-    subtensor.substrate.submit_extrinsic.return_value.is_success = False
-
-    mocked_format_error_message = mocker.MagicMock()
-    subtensor_module.format_error_message = mocked_format_error_message
-
-    # Call
-    result = do_transfer(
-        subtensor,
-        fake_wallet,
-        fake_dest,
-        fake_transfer_balance,
-        fake_wait_for_inclusion,
-        fake_wait_for_finalization,
-    )
-
-    # Asserts
-    subtensor.substrate.compose_call.assert_called_once_with(
-        call_module="Balances",
-        call_function="transfer_allow_death",
-        call_params={"dest": fake_dest, "value": fake_transfer_balance.rao},
-    )
-    subtensor.substrate.create_signed_extrinsic.assert_called_once_with(
-        call=subtensor.substrate.compose_call.return_value, keypair=fake_wallet.coldkey
-    )
-    subtensor.substrate.submit_extrinsic.assert_called_once_with(
-        subtensor.substrate.create_signed_extrinsic.return_value,
-        wait_for_inclusion=fake_wait_for_inclusion,
-        wait_for_finalization=fake_wait_for_finalization,
-    )
-    subtensor.substrate.submit_extrinsic.return_value.process_events.assert_called_once()
-
-    assert result == (
-        False,
-        None,
-        subtensor.substrate.submit_extrinsic.return_value.error_message,
-    )
-
-
-def test_do_transfer_no_waits(subtensor, mocker):
-    """Successful do_transfer call."""
-    # Prep
-    fake_wallet = mocker.MagicMock()
-    fake_dest = "SS58PUBLICKEY"
-    fake_transfer_balance = Balance(1)
-    fake_wait_for_inclusion = False
-    fake_wait_for_finalization = False
+    mocked_execute_coroutine = mocker.patch.object(transfer, "execute_coroutine")
+    mocked_transfer_extrinsic = mocker.Mock()
+    transfer.async_transfer_extrinsic = mocked_transfer_extrinsic
 
     # Call
-    result = do_transfer(
-        subtensor,
-        fake_wallet,
-        fake_dest,
-        fake_transfer_balance,
-        fake_wait_for_inclusion,
-        fake_wait_for_finalization,
+    result = transfer.transfer_extrinsic(
+        subtensor=fake_subtensor,
+        wallet=fake_wallet,
+        dest=dest,
+        amount=amount,
+        transfer_all=transfer_all,
+        wait_for_inclusion=wait_for_inclusion,
+        wait_for_finalization=wait_for_finalization,
+        keep_alive=keep_alive,
     )
 
     # Asserts
-    subtensor.substrate.compose_call.assert_called_once_with(
-        call_module="Balances",
-        call_function="transfer_allow_death",
-        call_params={"dest": fake_dest, "value": fake_transfer_balance.rao},
-    )
-    subtensor.substrate.create_signed_extrinsic.assert_called_once_with(
-        call=subtensor.substrate.compose_call.return_value, keypair=fake_wallet.coldkey
-    )
-    subtensor.substrate.submit_extrinsic.assert_called_once_with(
-        subtensor.substrate.create_signed_extrinsic.return_value,
-        wait_for_inclusion=fake_wait_for_inclusion,
-        wait_for_finalization=fake_wait_for_finalization,
-    )
-    assert result == (True, None, None)
+    mocked_execute_coroutine.assert_called_once_with(
+        coroutine=mocked_transfer_extrinsic.return_value,
+        event_loop=fake_subtensor.event_loop,
+    )
+    mocked_transfer_extrinsic.assert_called_once_with(
+        subtensor=fake_subtensor.async_subtensor,
+        wallet=fake_wallet,
+        destination=dest,
+        amount=amount,
+        transfer_all=transfer_all,
+        wait_for_inclusion=wait_for_inclusion,
+        wait_for_finalization=wait_for_finalization,
+        keep_alive=keep_alive,
+    )
+    assert result == mocked_execute_coroutine.return_value