Skip to content

AsyncSubstrateInterface Overhaul (with Sync AsyncSubstrate) #2526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 223 commits into from
Jan 11, 2025
Merged

AsyncSubstrateInterface Overhaul (with Sync AsyncSubstrate) #2526

merged 223 commits into from
Jan 11, 2025

Conversation

@thewhaleking
Copy link
Contributor

@thewhaleking thewhaleking commented Dec 6, 2024 •
edited
Loading

Before merging, this needs to be thoroughly manually tested.

Changes Subtensor (not AsyncSubtensor) to use AsyncSubstrateInterface through a wrapper. Adjusts the rest of Subtensor to handle this (including tests). Also improves the handling of reconnection in AsyncSubstrateInterface, which directly improves the sync version of it.

Removes all our ensure_connected wrappers, because we are now able to do the reconnection logic directly in the (Async)SubstrateInterface

TODO:

  • Port all methods of py-substrate-interface to async substrate interface
  • Port all methods of subtensor to async_subtensor
  • Improve connection logic
  • Make SubstrateInterface use AsyncSubstrateInterface
  • Remove all non-AsyncSubstrateInterface-level reconnection handling/logic
  • Speed

Important to know for users of release:

  • All py-substrate-interface exceptions (especially SubstrateRequestException) will need to be caught from bittensor.core.errors rather than substrateinterface.exceptions.
  • The base websocket object inside SubstrateInterface has changed.

@thewhaleking thewhaleking marked this pull request as ready for review December 10, 2024 12:53
@thewhaleking thewhaleking changed the title [WIP] sync AsyncSubstrateInterface Sync AsyncSubstrateInterface Dec 10, 2024
@thewhaleking thewhaleking requested a review from a team December 10, 2024 13:59
@thewhaleking thewhaleking force-pushed the feat/thewhaleking/new-sync-substrate branch 2 times, most recently from d81be92 to a35276a Compare December 10, 2024 18:32
thewhaleking
thewhaleking commented Dec 10, 2024
View reviewed changes
This was referenced Dec 10, 2024
Closed
Merged
@thewhaleking thewhaleking changed the title Sync AsyncSubstrateInterface AsyncSubstrateInterface Overhaul (with Sync AsyncSubstrate) Dec 12, 2024
@thewhaleking thewhaleking force-pushed the feat/thewhaleking/new-sync-substrate branch 3 times, most recently from e5c8451 to 8383fce Compare December 16, 2024 17:49
@thewhaleking thewhaleking marked this pull request as draft December 16, 2024 20:04
@thewhaleking thewhaleking force-pushed the feat/thewhaleking/new-sync-substrate branch 2 times, most recently from 914b86a to 59778da Compare December 16, 2024 23:01
@basfroman basfroman mentioned this pull request Dec 17, 2024
Closed
1 task
thewhaleking and others added 22 commits January 9, 2025 16:31
@thewhaleking
More stripping of py-substrate-interface
19ac760
@thewhaleking
Completely removed py-substrate-interface.
dc60e03
@thewhaleking
Docstrings update
d897b70
@thewhaleking
Fix tests
4609355
@thewhaleking
Merge branch 'staging' into feat/thewhaleking/new-sync-substrate
9a669a4
@thewhaleking
Name shadowing.
46a1468
@thewhaleking
Import/type fixes.
5913108
@thewhaleking
Return self from __aenter__
9ec7acf
@thewhaleking
Ensure correct loop is used always
b31764f
@thewhaleking
Use async_substrate_interface rather than the local version.
6106c18
@thewhaleking
Update utils
66c64a8
replace imports + cleanup + ruff
9dcfcae
temporally use repo instead of pypi package
0bda527
ruff
344a412
@basfroman
Merge pull request #2572 from opentensor/feat/thewhaleking/use-library
1f85164 
Uses the new async_substrate_interface lib
update deps
2aec7f6
update deps
c99aaee
Merge remote-tracking branch 'origin/feat/thewhaleking/new-sync-subst…
528817c 
…rate' into feat/thewhaleking/new-sync-substrate

# Conflicts:
#	requirements/prod.txt
update deps
ee6f834
update deps
c31520e
add nonce to root set weights
6b8776e
fix unit test
3eead3a
@basfroman basfroman changed the base branch from staging to staging-pre-merge-new-async January 11, 2025 00:14
@basfroman basfroman changed the title [DO NOT MERGE] AsyncSubstrateInterface Overhaul (with Sync AsyncSubstrate) AsyncSubstrateInterface Overhaul (with Sync AsyncSubstrate) Jan 11, 2025
@basfroman basfroman merged commit 110a281 into staging-pre-merge-new-async Jan 11, 2025
30 checks passed
@basfroman basfroman deleted the feat/thewhaleking/new-sync-substrate branch January 11, 2025 00:15
@thewhaleking thewhaleking linked an issue Jan 13, 2025 that may be closed by this pull request
AsyncSubtensor needs all Subtensor methods #2517
Closed
@ibraheem-abe ibraheem-abe mentioned this pull request Feb 13, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@basfroman basfroman basfroman approved these changes

Assignees

No one assigned

Labels

async migration

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AsyncSubtensor needs all Subtensor methods

4 participants

@thewhaleking @zyzniewski-reef @basfroman