feat(radio): [radio] Component dark theme adaptation

[Youyou-smiles]

feat(radio): [radio] Component dark theme adaptation

Summary by CodeRabbit

• Style
  • Enhanced the visual styling for disabled radio buttons by refining the border and background colors, ensuring a more consistent and modern design across the interface.

[coderabbitai]

Walkthrough

The pull request updates the CSS variables for the disabled state of radio buttons in the theme package. In the vars.less file, the border color and inner background color for disabled, checked radio buttons are modified to reference new color variables. This adjustment refines the visual styling for the disabled radio state and updates inline comments with design hints. The changes are confined exclusively to style variables with no additional control flow or functional modifications.

Changes

File	Change Summary
packages/.../vars.less	Updated CSS variables for disabled radio buttons: changed --tv-Radio-input-checked-disabled-border-color from var(--tv-color-border-disabled) to var(--tv-color-bg-disabled-control-checked-1) and --tv-Radio-inner-checked-disabled-bg-color from var(--tv-color-bg-disabled-control-checked) to var(--tv-color-bg-disabled-control-checked-1) with corresponding comment updates.

Possibly related PRs

• feat(radio): [radio] Adapting to the SMB theme  #1982: Related to CSS variable updates for the disabled state of radio buttons.
• feat(radio): [radio] Adapting to the SMB theme #1959: Involves similar modifications to radio button disabled styling in the vars.less file.
• refactor(radio): [radio] refactor radio theme #2181: Addresses a comprehensive update of CSS variable names and values for the radio component.

Suggested labels

enhancement

Suggested reviewers

• zzcr

Poem

In the code garden, I happily hop,
Adjusting colors until the styles pop.
Variables change with a gentle tweak,
Disabled radios now play unique.
I’m a coding rabbit, dancing with glee—
Styling updates as vibrant as can be!

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 47050d0 and ee15299.

📒 Files selected for processing (1)

• packages/theme/src/radio/vars.less (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

• GitHub Check: PR E2E Test (pnpm test:e2e3)

🔇 Additional comments (2)

packages/theme/src/radio/vars.less (2)

37-37: Ensure Correct Dark Theme Variable Usage for Disabled Border

The updated variable --tv-Radio-input-checked-disabled-border-color now points to var(--tv-color-bg-disabled-control-checked-1) with an inline comment specifying dark theme color values. Please verify that the referenced variable is defined in your theme palette and that the comment accurately reflects the intended color codes.

---

47-47: Verify Consistency for Disabled Checked Background

The change for --tv-Radio-inner-checked-disabled-bg-color to use var(--tv-color-bg-disabled-control-checked-1) is consistent with the dark theme requirements. Confirm that this new variable is uniformly applied across components for the disabled checked state and the comment’s color details match the design guidelines.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[petercat-assistant]

Walkthrough

This pull request adapts the radio component to support a dark theme. It modifies the color variables to ensure that the radio component displays correctly in dark mode, focusing on the checked and disabled states.

Changes

Files	Summary
packages/theme/src/radio/vars.less	Updated color variables for checked-disabled border and inner background to support dark theme adaptation.

[MomoPoppy]

此处讨论后，补充 --tv-color-bg-disabled-control-checked-1
暗色：--tv-color-bg-disabled-control-checked-1：#264dab
浅色：--tv-color-bg-disabled-control-checked-1：#dbdbdb
因为暂时没有补充radio场景的禁用边框色，此处讨论结果是，如果任何主题下，选中且禁用的边框色和中心远点背景色都是一致的话，那么
--tv-Radio-input-checked-disabled-border-color：var(--tv-Radio-inner-checked-disabled-bg-color);