From 543122c7d4db7a33aeac562e53b5d3f22d729282 Mon Sep 17 00:00:00 2001 From: superchilled Date: Wed, 16 Aug 2023 16:11:07 +0100 Subject: [PATCH 1/6] DEVX-6823: updating comments for Sip#dial --- lib/opentok/sip.rb | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/lib/opentok/sip.rb b/lib/opentok/sip.rb index 592213e..22506ae 100644 --- a/lib/opentok/sip.rb +++ b/lib/opentok/sip.rb @@ -38,13 +38,15 @@ class Sip # @option opts [true, false] :secure Whether the media must be transmitted # encrypted (​true​) or not (​false​, the default). # @option opts [true, false] :video Whether the SIP call will include - # video (​true​) or not (​false​, the default). With video included, the SIP - # client's video is included in the OpenTok stream that is sent to the - # OpenTok session. The SIP client will receive a single composed video of - # the published streams in the OpenTok session. + # video (​true​) or not (​false​, the default). With video included, the SIP + # client's video is included in the OpenTok stream that is sent to the + # OpenTok session. The SIP client will receive a single composed video of + # the published streams in the OpenTok session. # @option opts [true, false] :observe_force_mute Whether the SIP end point - # observes {https://tokbox.com/developer/guides/moderation/#force_mute force mute moderation} - # (true) or not (false, the default). + # observes {https://tokbox.com/developer/guides/moderation/#force_mute force mute moderation} + # (true) or not (false, the default). + # @option opts [Array] :streams An array of stream IDs for streams to include in the SIP call. + # If you do not set this property, all streams in the session are included in the call. def dial(session_id, token, sip_uri, opts) response = @client.dial(session_id, token, sip_uri, opts) end From dfe602f47bf11fff11bdb89e5458824fe089c84d Mon Sep 17 00:00:00 2001 From: superchilled Date: Wed, 16 Aug 2023 16:39:22 +0100 Subject: [PATCH 2/6] DEVX-7080: adding hasAudio & hasVideo to Broadcast --- lib/opentok/broadcast.rb | 6 ++++++ lib/opentok/broadcasts.rb | 12 ++++++++---- 2 files changed, 14 insertions(+), 4 deletions(-) diff --git a/lib/opentok/broadcast.rb b/lib/opentok/broadcast.rb index 97d2bd5..363290f 100644 --- a/lib/opentok/broadcast.rb +++ b/lib/opentok/broadcast.rb @@ -19,6 +19,12 @@ module OpenTok # @attr [int] updated_at # For this start method, this timestamp matches the createdAt timestamp. # + # @attr [boolean] hasAudio + # The broadcast has audio enabled + # + # @attr [boolean] hasVideo + # The broadcast has video enabled + # # @attr [string] resolution # The resolution of the broadcast: either "640x480" (SD landscape, the default), "1280x720" (HD landscape), # "1920x1080" (FHD landscape), "480x640" (SD portrait), "720x1280" (HD portrait), or "1080x1920" (FHD portrait). diff --git a/lib/opentok/broadcasts.rb b/lib/opentok/broadcasts.rb index e93b311..bb26eee 100644 --- a/lib/opentok/broadcasts.rb +++ b/lib/opentok/broadcasts.rb @@ -37,10 +37,10 @@ def initialize(client) # If you do not specify an initial layout type, the broadcast uses the best fit # layout type. # - # @option options [String] :multiBroadcastTag (Optional) Set this to support multiple broadcasts for the same session simultaneously. - # Set this to a unique string for each simultaneous broadcast of an ongoing session. Note that the `multiBroadcastTag` value is *not* included - # in the response for the methods to {https://tokbox.com/developer/rest/#list_broadcasts list live streaming broadcasts} and - # {https://tokbox.com/developer/rest/#get_info_broadcast get information about a live streaming broadcast}. + # @option options [String] :multiBroadcastTag (Optional) Set this to support multiple broadcasts for the same session simultaneously. + # Set this to a unique string for each simultaneous broadcast of an ongoing session. Note that the `multiBroadcastTag` value is *not* included + # in the response for the methods to {https://tokbox.com/developer/rest/#list_broadcasts list live streaming broadcasts} and + # {https://tokbox.com/developer/rest/#get_info_broadcast get information about a live streaming broadcast}. # {https://tokbox.com/developer/guides/broadcast/live-streaming#simultaneous-broadcasts See Simultaneous broadcasts}. # # @option options [int] maxDuration @@ -95,6 +95,10 @@ def initialize(client) # on {https://tokbox.com/developer/guides/archive-broadcast-layout/#stream-prioritization-rules stream prioritization rules}. # Important: this feature is currently available in the Standard environment only. # + # @option options [Boolean] :hasAudio Whether the broadcast has audio (default `true`) + # + # @option options [Boolean] :hasVideo Whether the broadcast has video (default `true`) + # # @return [Broadcast] The broadcast object, which includes properties defining the broadcast, # including the broadcast ID. # From d9cd13ad0fde6509653021bde4c489c84380f76c Mon Sep 17 00:00:00 2001 From: superchilled Date: Wed, 16 Aug 2023 18:57:41 +0100 Subject: [PATCH 3/6] DEVX-6829: adding maxBitRate property to Broadcast --- lib/opentok/broadcast.rb | 3 +++ lib/opentok/broadcasts.rb | 4 ++++ 2 files changed, 7 insertions(+) diff --git a/lib/opentok/broadcast.rb b/lib/opentok/broadcast.rb index 363290f..aacda23 100644 --- a/lib/opentok/broadcast.rb +++ b/lib/opentok/broadcast.rb @@ -19,6 +19,9 @@ module OpenTok # @attr [int] updated_at # For this start method, this timestamp matches the createdAt timestamp. # + # @attr [int] maxBitRate + # The maximum bitrate for the broadcast stream(s), in bits per second. + # # @attr [boolean] hasAudio # The broadcast has audio enabled # diff --git a/lib/opentok/broadcasts.rb b/lib/opentok/broadcasts.rb index bb26eee..18699b3 100644 --- a/lib/opentok/broadcasts.rb +++ b/lib/opentok/broadcasts.rb @@ -43,6 +43,10 @@ def initialize(client) # {https://tokbox.com/developer/rest/#get_info_broadcast get information about a live streaming broadcast}. # {https://tokbox.com/developer/guides/broadcast/live-streaming#simultaneous-broadcasts See Simultaneous broadcasts}. # + # @option options [int] maxBitRate + # The maximum bitrate for the broadcast stream(s), in bits per second. + # The minimum value is 100,000 and the maximum is 6,000,000. + # # @option options [int] maxDuration # The maximum duration for the broadcast, in seconds. The broadcast will automatically stop when # the maximum duration is reached. You can set the maximum duration to a value from 60 (60 seconds) to 36000 (10 hours). From 75cddc6f89917b7bf0ee300d1b705e56537c8af7 Mon Sep 17 00:00:00 2001 From: superchilled Date: Wed, 16 Aug 2023 19:22:59 +0100 Subject: [PATCH 4/6] DEVX-6830: adding hlsStatus to Broadcast --- lib/opentok/broadcast.rb | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/lib/opentok/broadcast.rb b/lib/opentok/broadcast.rb index aacda23..c50ed64 100644 --- a/lib/opentok/broadcast.rb +++ b/lib/opentok/broadcast.rb @@ -42,6 +42,12 @@ module OpenTok # You can include HLS, RTMP, or both as broadcast streams. If you include RTMP streaming, # you can specify up to five target RTMP streams (or just one). # The (:hls) property is set to an empty [Hash] object. The HLS URL is returned in the response. + # The `hlsStatus` property is set to one of the following: + # - "connecting" — The OpenTok server is in the process of starting transcoders. This is the initial state. + # - "ready" — The OpenTok server has succesfully initialized but the CDN is not consuming media. + # - "live" — The OpenTok server has succesfully initialized and the CDN is consuming media. + # - "ended" — The source stream has ended. If DVR is enabled and pre-recorded media is requested, then the status will transition to "live". + # - "error" — There is an error in the OpenTok platform. # The (:rtmp) property is set to an [Array] of Rtmp [Hash] properties. # For each RTMP stream, specify (:serverUrl) for the RTMP server URL, # (:streamName) such as the YouTube Live stream name or the Facebook stream key), From 1baa6ab615849d3b8f91dc15e82d5c523f69871f Mon Sep 17 00:00:00 2001 From: superchilled Date: Wed, 16 Aug 2023 19:59:25 +0100 Subject: [PATCH 5/6] Bumping patch version --- lib/opentok/version.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/opentok/version.rb b/lib/opentok/version.rb index be1ffff..faf23df 100644 --- a/lib/opentok/version.rb +++ b/lib/opentok/version.rb @@ -1,4 +1,4 @@ module OpenTok # @private - VERSION = '4.7.0' + VERSION = '4.7.1' end From afcdfc247a39ba523b9a181473bc81fa63cd90cf Mon Sep 17 00:00:00 2001 From: superchilled Date: Wed, 16 Aug 2023 20:00:34 +0100 Subject: [PATCH 6/6] Updating changelog --- CHANGES.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/CHANGES.md b/CHANGES.md index fef6abd..e181390 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -1,3 +1,7 @@ +# 4.7.1 + +* Updates docs comments for `Broadcasts` and `Sip` [#266](https://github.com/opentok/OpenTok-Ruby-SDK/pull/266) + # 4.7.0 * Adds support for the End-to-end encryption (E2EE) feature [#259](https://github.com/opentok/OpenTok-Ruby-SDK/pull/259)