From 26d8576cfade320f15f7847a3688a96b64815c70 Mon Sep 17 00:00:00 2001 From: Andrej Mihajlov Date: Tue, 14 Mar 2017 18:34:40 +0000 Subject: [PATCH 1/2] Make sure we do not create DOM element when insertDefaultUI is false Fixes issue #3 --- src/OTPublisher.js | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/src/OTPublisher.js b/src/OTPublisher.js index c3f75dc1..90807f7a 100644 --- a/src/OTPublisher.js +++ b/src/OTPublisher.js @@ -25,11 +25,16 @@ export default class OTPublisher extends Component { if (!this.props.session) { return; } + + let properties = this.props.properties || {}; + let container; - let container = document.createElement('div'); - findDOMNode(this).appendChild(container); + if(properties.insertDefaultUI !== false) { + container = document.createElement('div'); + findDOMNode(this).appendChild(container); + } - let publisher = OT.initPublisher(container, this.props.properties); + let publisher = OT.initPublisher(container, properties); publisher.on('streamCreated', this.streamCreatedHandler); if ( From a0a50be47bdf0bf5956ae1a9d0be48cd8859e6c2 Mon Sep 17 00:00:00 2001 From: Andrej Mihajlov Date: Wed, 15 Mar 2017 11:30:13 +0000 Subject: [PATCH 2/2] Add configuration test for insertDefaultUI --- test/OTPublisher.spec.js | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/test/OTPublisher.spec.js b/test/OTPublisher.spec.js index 48ead7a8..95a722eb 100644 --- a/test/OTPublisher.spec.js +++ b/test/OTPublisher.spec.js @@ -50,6 +50,19 @@ describe('OTPublisher', () => { ]); }); + describe('configuration', () => { + beforeEach(() => { + session.connection = {}; + }); + + it('should not render the publisher container element when default UI is disabled', () => { + const wrapper = mount(); + const divContainer = wrapper.render().find('div.OTPublisherContainer'); + expect(divContainer.length).toBe(0); + }); + + }); + describe('connected session', () => { let wrapper;