Skip to content
This repository has been archived by the owner on May 23, 2023. It is now read-only.

🛑 Deprecating OpenTracing #163

Open
2 of 4 tasks
yurishkuro opened this issue Jan 15, 2022 · 6 comments
Open
2 of 4 tasks

🛑 Deprecating OpenTracing #163

yurishkuro opened this issue Jan 15, 2022 · 6 comments
Assignees
@yurishkuro

Comments

@yurishkuro
Copy link
Member

yurishkuro commented Jan 15, 2022 •
edited
Loading

Practically all activity has moved to the OpenTelemetry project, there are no resources to maintain the OpenTracing API libraries any more. OpenTelemetry provides a compatibility layer for OpenTracing instrumentation.

After discussing with other Specification Council members, we propose to freeze all development of the OpenTracing APIs effective immediately:

  • No more new pull requests or feature requests will be accepted, only security fixes (which are unlikely given the nature of the API libraries).
  • Add a DEPRECATED banner to the website: Change banner to say project is deprecated opentracing.io#460
  • All API repos will be tagged as deprecated
  • All API repos will be archived by the end of 2022.

cc @carlosalberto @tedsuo @bhs
@yurishkuro yurishkuro self-assigned this Jan 15, 2022
@bhs
Copy link
Contributor

bhs commented Jan 18, 2022

"LGTM" 😿

Thank you for taking the initiative on this, Yuri.

@carlosalberto
Copy link
Contributor

Sounds good to me, thanks! And definitely good motivation to finish the latest cycles in the compatibility section in OTel.

@yurishkuro yurishkuro mentioned this issue Feb 14, 2022
Open
@yurishkuro yurishkuro changed the title Deprecating OpenTracing 🛑 Deprecating OpenTracing Feb 14, 2022
@yurishkuro yurishkuro pinned this issue Feb 14, 2022
@fscellos fscellos mentioned this issue Feb 16, 2022
Closed
@AlexanderYastrebov AlexanderYastrebov mentioned this issue Feb 21, 2022
Merged
@dekimsey dekimsey mentioned this issue Apr 6, 2022
Open
@borkke borkke mentioned this issue May 14, 2022
Closed
This was referenced Jun 8, 2022
Closed
Closed
@wuriyanto48 wuriyanto48 mentioned this issue Jun 13, 2022
Closed
@webVueBlog webVueBlog mentioned this issue Jun 24, 2022
Open
@aivinog1 aivinog1 mentioned this issue Jun 29, 2022
Closed
@HarryET HarryET mentioned this issue Jun 30, 2022
Closed
This was referenced Jul 18, 2022
Merged
Merged
bors bot added a commit to onflow/flow-go that referenced this issue Jul 26, 2022
@bors @SaveTheRbtz
Merge #2823
f9c16a5 
2823: [All] OpenTracing to OpenTelemetry migration r=SaveTheRbtz a=SaveTheRbtz

Issue: #2796

OpenTracing spec is deprecated: opentracing/specification#163.  Switching to the supported OpenTelemetry implementation.

Note that new tracing code would honor [OTEL env vars](https://github.com/open-telemetry/opentelemetry-specification/blob/v1.12.0/specification/protocol/exporter.md) instead of JAEGER ones, e.g.:
`JAEGER_ENDPOINT` -> `OTEL_EXPORTER_OTLP_TRACES_ENDPOINT`, `OTEL_EXPORTER_OTLP_TRACES_INSECURE`, etc

(cc: `@sjonpaulbrown` `@haroldsphinx)`

New API is slightly slower and consumes more memory but does substantially less allocs (~ -50%):
```
name                              old time/op    new time/op    delta
StartSpanFromParent-8                485ns ± 6%     639ns ± 1%  +31.71%  (p=0.000 n=10+9)
StartTransactionSpan/cacheHit-8      993ns ± 4%     927ns ± 3%   -6.69%  (p=0.000 n=10+10)
StartTransactionSpan/cacheMiss-8    2.24µs ± 1%    2.19µs ± 1%   -2.42%  (p=0.000 n=10+10)

name                              old alloc/op   new alloc/op   delta
StartSpanFromParent-8                 577B ± 0%      864B ± 0%  +49.74%  (p=0.000 n=10+10)
StartTransactionSpan/cacheHit-8       776B ± 1%      944B ± 0%  +21.65%  (p=0.000 n=10+8)
StartTransactionSpan/cacheMiss-8    2.16kB ± 1%    2.39kB ± 0%  +10.62%  (p=0.000 n=10+10)

name                              old allocs/op  new allocs/op  delta
StartSpanFromParent-8                 7.00 ± 0%      4.00 ± 0%  -42.86%  (p=0.000 n=10+10)
StartTransactionSpan/cacheHit-8       10.3 ± 7%       6.0 ± 0%  -41.75%  (p=0.000 n=10+10)
StartTransactionSpan/cacheMiss-8      35.3 ± 2%      18.0 ± 0%  -49.01%  (p=0.000 n=10+10)
```

An example of both extensive tracing and cadence tracing enabled:
<img width="1459" alt="Screen Shot 2022-07-25 at 10 21 07 PM" src="https://user-images.githubusercontent.com/169976/180929610-edbfdc54-e604-401f-aea5-501af2f861b2.png">

- [x] test against localnet's Tempo instance.
- [x] noop tracer.
- [x] log tracer.
- [x] merge cadence bits onflow/cadence#1824.
- [x] merge onflow/flow-core-contracts#298.
- [x] update cadence.

Co-authored-by: Alexey Ivanov <rbtz@dapperlabs.com>
@kavirajk kavirajk mentioned this issue Jul 31, 2022
Open
@kavirajk kavirajk mentioned this issue Aug 15, 2022
Open
@janiskemper janiskemper mentioned this issue Sep 12, 2022
Open
@orloffv orloffv mentioned this issue Sep 14, 2022
Open
@wbarnha wbarnha mentioned this issue Oct 6, 2022
Merged
This was referenced Oct 14, 2022
Closed
Open
@welschsn welschsn mentioned this issue Nov 17, 2022
Open
@Tantalor93 Tantalor93 mentioned this issue Nov 27, 2022
Closed
@chalin
Copy link

chalin commented Dec 17, 2022

We've pretty much reached the end of 2022, will the repos under this org be (GitHub) archived soon? /cc @caniszczyk

@yurishkuro yurishkuro mentioned this issue Feb 22, 2023
Open
@rogerogers rogerogers mentioned this issue Apr 28, 2023
Merged
3 tasks
@AlekSi
Copy link

AlekSi commented May 23, 2023

It would be nice to archive that repo to save some time for people reading outdated issues (like me)

@carlosalberto
Copy link
Contributor

@yurishkuro Sounds like we are ready to roll?

@austinlparker
Copy link
Member

Yeah we should go ahead and archive all of these.

@lucastt lucastt mentioned this issue May 24, 2023
Open
@jonathankretzmer jonathankretzmer mentioned this issue May 31, 2023
Closed
@Oberon00 Oberon00 mentioned this issue Aug 7, 2023
Closed
@AndersonTorres AndersonTorres mentioned this issue Oct 18, 2023
Open
@cwe1ss cwe1ss mentioned this issue Oct 19, 2023
Closed
This was referenced Dec 6, 2023
Closed
Closed
Closed
@Oberon00 Oberon00 mentioned this issue Jan 26, 2024
Open
@shellshock1953 shellshock1953 mentioned this issue Feb 20, 2024
Closed
@samford samford mentioned this issue Mar 10, 2024
Merged
6 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@yurishkuro yurishkuro

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@AlekSi @carlosalberto @bhs @yurishkuro @austinlparker @chalin