Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mergeback 1.9.1 to develop #1623

Merged
merged 5 commits into from
Sep 27, 2024

Conversation

yunchu
Copy link
Contributor

@yunchu yunchu commented Sep 27, 2024

Summary

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2024 Intel Corporation
#
# SPDX-License-Identifier: MIT

sooahleex and others added 4 commits September 20, 2024 11:25
- Ticket no.152153
- Support multi labels for kaggle dataset
- Add unit tests
<!-- Contributing guide:
https://github.com/openvinotoolkit/datumaro/blob/develop/CONTRIBUTING.md
-->

### Summary

When importing a stream dataset with multiple sources in eager mode by
specifying `error_policy` or `progress_reporting`, an error occurs:
```
'_MergedStreamDataset' object has no attribute '_data'
```

<!--
Resolves openvinotoolkit#111 and openvinotoolkit#222.
Depends on openvinotoolkit#1000 (for series of dependent commits).

This PR introduces this capability to make the project better in this
and that.

- Added this feature
- Removed that feature
- Fixed the problem openvinotoolkit#1234
-->

### How to test
<!-- Describe the testing procedure for reviewers, if changes are
not fully covered by unit tests or manual testing can be complicated.
-->

### Checklist
<!-- Put an 'x' in all the boxes that apply -->
- [x] I have added unit tests to cover my changes.​
- [x] I have added integration tests to cover my changes.​
- [x] I have added the description of my changes into
[CHANGELOG](https://github.com/openvinotoolkit/datumaro/blob/develop/CHANGELOG.md).​
- [x] I have updated the
[documentation](https://github.com/openvinotoolkit/datumaro/tree/develop/docs)
accordingly

### License

- [x] I submit _my code changes_ under the same [MIT
License](https://github.com/openvinotoolkit/datumaro/blob/develop/LICENSE)
that covers the project.
  Feel free to contact the maintainers if that's a concern.
- [x] I have updated the license header for each file (see an example
below).

```python
# Copyright (C) 2024 Intel Corporation
#
# SPDX-License-Identifier: MIT
```

---------

Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Ilya Trushkin <ilya.trushkin@intel.com>
Co-authored-by: williamcorsel <31770711+williamcorsel@users.noreply.github.com>
Co-authored-by: Sooah Lee <sooah.lee@intel.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Yunchu Lee <yunchu.lee@intel.com>
Co-authored-by: Wonju Lee <wonju.lee@intel.com>
- Use `DataFrame.map` instead of `DataFrame.applymap`
- `DataFrame.applymap` has been deprecated.
@yunchu yunchu requested review from a team as code owners September 27, 2024 04:49
@yunchu yunchu requested review from sooahleex and removed request for a team September 27, 2024 04:49
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 4 lines in your changes missing coverage. Please review.

Project coverage is 81.12%. Comparing base (ff5fd94) to head (ae2eda5).
Report is 8 commits behind head on develop.

Files with missing lines Patch % Lines
src/datumaro/plugins/data_formats/kaggle/base.py 92.30% 2 Missing and 1 partial ⚠️
src/datumaro/components/dataset.py 87.50% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1623      +/-   ##
===========================================
+ Coverage    81.06%   81.12%   +0.05%     
===========================================
  Files          278      281       +3     
  Lines        32517    32746     +229     
  Branches      6607     6645      +38     
===========================================
+ Hits         26360    26565     +205     
- Misses        4701     4721      +20     
- Partials      1456     1460       +4     
Flag Coverage Δ
ubuntu-20.04_Python-3.10 81.10% <91.66%> (+0.05%) ⬆️
windows-2022_Python-3.10 81.10% <91.66%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chuneuny-emily chuneuny-emily merged commit fdd1ac2 into openvinotoolkit:develop Sep 27, 2024
8 checks passed
@yunchu yunchu deleted the mergeback/1.9.1 branch September 27, 2024 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants