-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Scope for VCS #445
Use Scope for VCS #445
Commits on Sep 2, 2021
-
Maxim Zhiltsov committed
Sep 2, 2021 Configuration menu - View commit details
-
Copy full SHA for 9b1c687 - Browse repository at this point
Copy the full SHA 9b1c687View commit details -
Maxim Zhiltsov committed
Sep 2, 2021 Configuration menu - View commit details
-
Copy full SHA for 0f823cf - Browse repository at this point
Copy the full SHA 0f823cfView commit details -
Maxim Zhiltsov committed
Sep 2, 2021 Configuration menu - View commit details
-
Copy full SHA for 655505a - Browse repository at this point
Copy the full SHA 655505aView commit details -
Maxim Zhiltsov committed
Sep 2, 2021 Configuration menu - View commit details
-
Copy full SHA for 73d7b3f - Browse repository at this point
Copy the full SHA 73d7b3fView commit details -
Maxim Zhiltsov committed
Sep 2, 2021 Configuration menu - View commit details
-
Copy full SHA for e75c7ab - Browse repository at this point
Copy the full SHA e75c7abView commit details
Commits on Sep 3, 2021
-
Merge branch 'zm/add-scope' into zm/test-scoped-with-vcs
Maxim Zhiltsov committedSep 3, 2021 Configuration menu - View commit details
-
Copy full SHA for baf6b88 - Browse repository at this point
Copy the full SHA baf6b88View commit details -
Maxim Zhiltsov committed
Sep 3, 2021 Configuration menu - View commit details
-
Copy full SHA for 564957d - Browse repository at this point
Copy the full SHA 564957dView commit details -
Replace rollback with scoped in the project
Maxim Zhiltsov committedSep 3, 2021 Configuration menu - View commit details
-
Copy full SHA for 51d871e - Browse repository at this point
Copy the full SHA 51d871eView commit details -
Maxim Zhiltsov committed
Sep 3, 2021 Configuration menu - View commit details
-
Copy full SHA for 6b5034c - Browse repository at this point
Copy the full SHA 6b5034cView commit details -
lazy_image: fix cache collisions leading to unrelated data being retu…
…rned (#443) * lazy_image: fix cache collisions leading to unrelated data being returned Currently, the key used to look up the cached image is based on a hash of a tuple containing `id(self)`, `path`, and `loader`. This means there are two situations in which a `lazy_image` can look up the wrong data: * If there previously existed another `lazy_image` object whose `self` and `loader` had the same object IDs as the current `lazy_image`'s `self` and `loader`. This is possible, because deleted objects' IDs can be reused. * If a hash collision occurs between the current `lazy_image`'s tuple and some other's. Fix it by using a weak reference to `self` as the key instead. Different weak references will only compare equal if they point to the same object. This will only work correctly if the loader and path of a `lazy_image` are not modified after creation. I don't think there are any use cases for modifying them (and there are no instances of that happening in the codebase), so it shouldn't be an issue. To reduce the temptation of client code to modify these fields, mark them as private. Modifying the `cache` field should not cause issues, but just in case, make it private as well. * Add a changelog entry for the lazy_image cache collision fix
Roman Donchenko authoredSep 3, 2021 Configuration menu - View commit details
-
Copy full SHA for df4a0d6 - Browse repository at this point
Copy the full SHA df4a0d6View commit details
Commits on Sep 6, 2021
-
Replace Rollback with Scope (#444)
* Replace rollback with scope * Add scope_add() function * Update tests * Replace rollback uses * Update changelog
Maxim Zhiltsov authoredSep 6, 2021 Configuration menu - View commit details
-
Copy full SHA for 7f2ca57 - Browse repository at this point
Copy the full SHA 7f2ca57View commit details -
Merge branch 'develop' into zm/test-scoped-with-vcs
Maxim Zhiltsov committedSep 6, 2021 Configuration menu - View commit details
-
Copy full SHA for 80d075a - Browse repository at this point
Copy the full SHA 80d075aView commit details -
Maxim Zhiltsov committed
Sep 6, 2021 Configuration menu - View commit details
-
Copy full SHA for ca1c60d - Browse repository at this point
Copy the full SHA ca1c60dView commit details -
Maxim Zhiltsov committed
Sep 6, 2021 Configuration menu - View commit details
-
Copy full SHA for a434eb8 - Browse repository at this point
Copy the full SHA a434eb8View commit details -
Maxim Zhiltsov committed
Sep 6, 2021 Configuration menu - View commit details
-
Copy full SHA for 559e096 - Browse repository at this point
Copy the full SHA 559e096View commit details -
Fix windows file addition in git
Maxim Zhiltsov committedSep 6, 2021 Configuration menu - View commit details
-
Copy full SHA for 8323e2e - Browse repository at this point
Copy the full SHA 8323e2eView commit details -
Maxim Zhiltsov committed
Sep 6, 2021 Configuration menu - View commit details
-
Copy full SHA for 5ea8e1a - Browse repository at this point
Copy the full SHA 5ea8e1aView commit details
Commits on Sep 7, 2021
-
Maxim Zhiltsov committed
Sep 7, 2021 Configuration menu - View commit details
-
Copy full SHA for e773b86 - Browse repository at this point
Copy the full SHA e773b86View commit details -
Maxim Zhiltsov committed
Sep 7, 2021 Configuration menu - View commit details
-
Copy full SHA for 83cc4fc - Browse repository at this point
Copy the full SHA 83cc4fcView commit details -
Maxim Zhiltsov committed
Sep 7, 2021 Configuration menu - View commit details
-
Copy full SHA for ba5b78e - Browse repository at this point
Copy the full SHA ba5b78eView commit details -
Maxim Zhiltsov committed
Sep 7, 2021 Configuration menu - View commit details
-
Copy full SHA for c4dd0a8 - Browse repository at this point
Copy the full SHA c4dd0a8View commit details -
Dont hide windows file femoval issues
Maxim Zhiltsov committedSep 7, 2021 Configuration menu - View commit details
-
Copy full SHA for cb4f0ab - Browse repository at this point
Copy the full SHA cb4f0abView commit details