Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Scope for VCS #445

Merged
merged 22 commits into from
Sep 7, 2021
Merged

Use Scope for VCS #445

merged 22 commits into from
Sep 7, 2021

Commits on Sep 2, 2021

  1. Replace rollback with scope

    Maxim Zhiltsov committed Sep 2, 2021
    Configuration menu
    Copy the full SHA
    9b1c687 View commit details
    Browse the repository at this point in the history
  2. Update tests

    Maxim Zhiltsov committed Sep 2, 2021
    Configuration menu
    Copy the full SHA
    0f823cf View commit details
    Browse the repository at this point in the history
  3. Replace rollback uses

    Maxim Zhiltsov committed Sep 2, 2021
    Configuration menu
    Copy the full SHA
    655505a View commit details
    Browse the repository at this point in the history
  4. Fix imports

    Maxim Zhiltsov committed Sep 2, 2021
    Configuration menu
    Copy the full SHA
    73d7b3f View commit details
    Browse the repository at this point in the history
  5. update changelog

    Maxim Zhiltsov committed Sep 2, 2021
    Configuration menu
    Copy the full SHA
    e75c7ab View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2021

  1. Merge branch 'zm/add-scope' into zm/test-scoped-with-vcs

    Maxim Zhiltsov committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    baf6b88 View commit details
    Browse the repository at this point in the history
  2. Fix add() type anns in Scope

    Maxim Zhiltsov committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    564957d View commit details
    Browse the repository at this point in the history
  3. Replace rollback with scoped in the project

    Maxim Zhiltsov committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    51d871e View commit details
    Browse the repository at this point in the history
  4. Update revpath tests

    Maxim Zhiltsov committed Sep 3, 2021
    Configuration menu
    Copy the full SHA
    6b5034c View commit details
    Browse the repository at this point in the history
  5. lazy_image: fix cache collisions leading to unrelated data being retu…

    …rned (#443)
    
    * lazy_image: fix cache collisions leading to unrelated data being returned
    
    Currently, the key used to look up the cached image is based on a hash of
    a tuple containing `id(self)`, `path`, and `loader`. This means there are two
    situations in which a `lazy_image` can look up the wrong data:
    
    * If there previously existed another `lazy_image` object whose `self` and
      `loader` had the same object IDs as the current `lazy_image`'s `self` and
      `loader`. This is possible, because deleted objects' IDs can be reused.
    
    * If a hash collision occurs between the current `lazy_image`'s tuple and
      some other's.
    
    Fix it by using a weak reference to `self` as the key instead. Different weak
    references will only compare equal if they point to the same object.
    
    This will only work correctly if the loader and path of a `lazy_image` are
    not modified after creation. I don't think there are any use cases for
    modifying them (and there are no instances of that happening in the codebase),
    so it shouldn't be an issue. To reduce the temptation of client code to modify
    these fields, mark them as private.
    
    Modifying the `cache` field should not cause issues, but just in case, make it
    private as well.
    
    * Add a changelog entry for the lazy_image cache collision fix
    Roman Donchenko authored Sep 3, 2021
    Configuration menu
    Copy the full SHA
    df4a0d6 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2021

  1. Replace Rollback with Scope (#444)

    * Replace rollback with scope
    
    * Add scope_add() function
    
    * Update tests
    
    * Replace rollback uses
    
    * Update changelog
    Maxim Zhiltsov authored Sep 6, 2021
    Configuration menu
    Copy the full SHA
    7f2ca57 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'develop' into zm/test-scoped-with-vcs

    Maxim Zhiltsov committed Sep 6, 2021
    Configuration menu
    Copy the full SHA
    80d075a View commit details
    Browse the repository at this point in the history
  3. Update imports

    Maxim Zhiltsov committed Sep 6, 2021
    Configuration menu
    Copy the full SHA
    ca1c60d View commit details
    Browse the repository at this point in the history
  4. Update on_error_do call

    Maxim Zhiltsov committed Sep 6, 2021
    Configuration menu
    Copy the full SHA
    a434eb8 View commit details
    Browse the repository at this point in the history
  5. Update TestDir class

    Maxim Zhiltsov committed Sep 6, 2021
    Configuration menu
    Copy the full SHA
    559e096 View commit details
    Browse the repository at this point in the history
  6. Fix windows file addition in git

    Maxim Zhiltsov committed Sep 6, 2021
    Configuration menu
    Copy the full SHA
    8323e2e View commit details
    Browse the repository at this point in the history
  7. Apply scoped to project tests

    Maxim Zhiltsov committed Sep 6, 2021
    Configuration menu
    Copy the full SHA
    5ea8e1a View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2021

  1. Fix source dvcfile placement

    Maxim Zhiltsov committed Sep 7, 2021
    Configuration menu
    Copy the full SHA
    e773b86 View commit details
    Browse the repository at this point in the history
  2. Fix winodws issues

    Maxim Zhiltsov committed Sep 7, 2021
    Configuration menu
    Copy the full SHA
    83cc4fc View commit details
    Browse the repository at this point in the history
  3. Update cli tests

    Maxim Zhiltsov committed Sep 7, 2021
    Configuration menu
    Copy the full SHA
    ba5b78e View commit details
    Browse the repository at this point in the history
  4. Suppress extra window

    Maxim Zhiltsov committed Sep 7, 2021
    Configuration menu
    Copy the full SHA
    c4dd0a8 View commit details
    Browse the repository at this point in the history
  5. Dont hide windows file femoval issues

    Maxim Zhiltsov committed Sep 7, 2021
    Configuration menu
    Copy the full SHA
    cb4f0ab View commit details
    Browse the repository at this point in the history