Skip to content

Conversation

@AlexanderDokuchaev
Copy link
Collaborator

@AlexanderDokuchaev AlexanderDokuchaev commented Apr 15, 2025

Reason for changes

No need after #3338

https://github.com/openvinotoolkit/nncf/actions/runs/14470409240
manual/job/post_training_quantization/648

@github-actions github-actions bot added documentation Improvements or additions to documentation NNCF PTQ Pull requests that updates NNCF PTQ labels Apr 15, 2025
@AlexanderDokuchaev AlexanderDokuchaev marked this pull request as ready for review April 15, 2025 13:50
@AlexanderDokuchaev AlexanderDokuchaev requested a review from a team as a code owner April 15, 2025 13:50
Copy link
Collaborator

@daniil-lyakhov daniil-lyakhov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Minor comments

@daniil-lyakhov daniil-lyakhov self-requested a review April 15, 2025 13:58
@daniil-lyakhov
Copy link
Collaborator

Could you please update the torch fx pre-commit tests? From tests/torch/fx/?

@AlexanderDokuchaev
Copy link
Collaborator Author

Could you please update the torch fx pre-commit tests? From tests/torch/fx/?

Not now

@daniil-lyakhov
Copy link
Collaborator

Could you please update the torch fx pre-commit tests? From tests/torch/fx/?

Not now

I did it for you AlexanderDokuchaev#39

Please accept

@daniil-lyakhov
Copy link
Collaborator

Could you please update the torch fx pre-commit tests? From tests/torch/fx/?

Not now

I did it for you AlexanderDokuchaev#39

Please accept

Torch FX tests should be refactored due to this env https://github.com/openvinotoolkit/nncf/blob/develop/tests/torch/conftest.py#L126

@AlexanderDokuchaev AlexanderDokuchaev merged commit 09269bf into openvinotoolkit:develop Apr 15, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation NNCF PTQ Pull requests that updates NNCF PTQ

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants